From edeccef4990598620bf5595df6fc8c1b1b1a7f73 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Sat, 7 Oct 2023 17:34:03 +0200 Subject: refactor: migrate more ops to op2 macro (#20808) Getting closer... --- cli/ops/testing.rs | 5 +---- cli/tools/upgrade.rs | 2 ++ 2 files changed, 3 insertions(+), 4 deletions(-) (limited to 'cli') diff --git a/cli/ops/testing.rs b/cli/ops/testing.rs index cb3788cdc..7454670c6 100644 --- a/cli/ops/testing.rs +++ b/cli/ops/testing.rs @@ -1,9 +1,5 @@ // Copyright 2018-2023 the Deno authors. All rights reserved. MIT license. -// TODO: allow everywhere because `#[allow(clippy::too_many_arguments)]` on -// `#[op(fast)]` does not work. https://github.com/denoland/rusty_v8/issues/1332 -#![allow(clippy::too_many_arguments)] - use crate::tools::test::TestDescription; use crate::tools::test::TestEvent; use crate::tools::test::TestEventSender; @@ -117,6 +113,7 @@ struct TestRegisterResult { static NEXT_ID: AtomicUsize = AtomicUsize::new(0); +#[allow(clippy::too_many_arguments)] #[op2] #[string] fn op_register_test( diff --git a/cli/tools/upgrade.rs b/cli/tools/upgrade.rs index 04332f5df..d2cb58d28 100644 --- a/cli/tools/upgrade.rs +++ b/cli/tools/upgrade.rs @@ -372,6 +372,8 @@ pub async fn upgrade( }; let download_url = if upgrade_flags.canary { + // NOTE(bartlomieju): to keep clippy happy on M1 macs. + #[allow(clippy::eq_op)] if env!("TARGET") == "aarch64-apple-darwin" { bail!("Canary builds are not available for M1/M2"); } -- cgit v1.2.3