From d856bfd336137e1bcf81a0db9e8ad2b418ba711e Mon Sep 17 00:00:00 2001 From: Divy Srivastava Date: Mon, 1 May 2023 10:39:30 +0530 Subject: perf(ext/web): fast path for ws events (#18905) - Do not use `ReflectHas` in `isNode`. - Avoid copying handler array when handlers.length == 1 - Avoid searching for path target when path.length == 1 ``` Linux divy-2 5.19.0-1022-gcp #24~22.04.1-Ubuntu SMP Sun Apr 23 09:51:08 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux 32GiB System memory Intel(R) Xeon(R) CPU @ 3.10GHz # main + https://github.com/denoland/deno/pull/18904 Msg/sec: 89326.750000 Msg/sec: 90320.000000 Msg/sec: 89576.250000 # this patch Msg/sec: 97250.000000 Msg/sec: 97125.500000 Msg/sec: 97964.500000 ``` --- cli/tests/testdata/run/event_listener_error_immediate_exit.ts.out | 4 ---- .../testdata/run/event_listener_error_immediate_exit_worker.ts.out | 6 +----- 2 files changed, 1 insertion(+), 9 deletions(-) (limited to 'cli') diff --git a/cli/tests/testdata/run/event_listener_error_immediate_exit.ts.out b/cli/tests/testdata/run/event_listener_error_immediate_exit.ts.out index 2b1b26444..8f03f71b8 100644 --- a/cli/tests/testdata/run/event_listener_error_immediate_exit.ts.out +++ b/cli/tests/testdata/run/event_listener_error_immediate_exit.ts.out @@ -3,8 +3,4 @@ error: Uncaught Error: bar throw new Error("bar"); ^ at [WILDCARD]/event_listener_error_immediate_exit.ts:4:9[WILDCARD] - at innerInvokeEventListeners (ext:deno_web/02_event.js:785:7) - at invokeEventListeners (ext:deno_web/02_event.js:825:5) - at dispatch (ext:deno_web/02_event.js:694:9) - at dispatchEvent (ext:deno_web/02_event.js:1086:12) at [WILDCARD]/event_listener_error_immediate_exit.ts:11:1 diff --git a/cli/tests/testdata/run/event_listener_error_immediate_exit_worker.ts.out b/cli/tests/testdata/run/event_listener_error_immediate_exit_worker.ts.out index 8ab76d6cf..85b52190b 100644 --- a/cli/tests/testdata/run/event_listener_error_immediate_exit_worker.ts.out +++ b/cli/tests/testdata/run/event_listener_error_immediate_exit_worker.ts.out @@ -2,11 +2,7 @@ error: Uncaught (in worker "") Error: bar throw new Error("bar"); ^ - at [WILDCARD]/event_listener_error_immediate_exit.ts:4:9 - at innerInvokeEventListeners (ext:deno_web/02_event.js:785:7) - at invokeEventListeners (ext:deno_web/02_event.js:825:5) - at dispatch (ext:deno_web/02_event.js:694:9) - at dispatchEvent (ext:deno_web/02_event.js:1086:12) + at [WILDCARD]/event_listener_error_immediate_exit.ts:4:9[WILDCARD] at [WILDCARD]/event_listener_error_immediate_exit.ts:11:1 error: Uncaught (in promise) Error: Unhandled error in child worker. at [WILDCARD] -- cgit v1.2.3