From d6452b39460ee46ade1ed9a5c95e469fd23a812c Mon Sep 17 00:00:00 2001 From: Nathan Whitaker <17734409+nathanwhit@users.noreply.github.com> Date: Mon, 25 Mar 2024 17:53:50 -0700 Subject: chore(tests): Introduce integration tests for `jupyter` subcommand (#23074) Before this PR, we didn't have any integration tests set up for the `jupyter` subcommand. This PR adds a basic jupyter client and helpers for writing integration tests for the jupyter kernel. A lot of the code here is boilerplate, mainly around the message format for jupyter. This also adds a few basic integration tests, most notably for requesting execution of a snippet of code and getting the correct results. --- cli/Cargo.toml | 2 +- cli/tools/jupyter/server.rs | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) (limited to 'cli') diff --git a/cli/Cargo.toml b/cli/Cargo.toml index 939dfee74..c252cd9b1 100644 --- a/cli/Cargo.toml +++ b/cli/Cargo.toml @@ -149,7 +149,7 @@ typed-arena = "=2.0.1" unicode-width = "0.1" uuid = { workspace = true, features = ["serde"] } walkdir = "=2.3.2" -zeromq = { version = "=0.3.4", default-features = false, features = ["tcp-transport", "tokio-runtime"] } +zeromq.workspace = true zstd.workspace = true [target.'cfg(windows)'.dependencies] diff --git a/cli/tools/jupyter/server.rs b/cli/tools/jupyter/server.rs index bfdcdf1e1..f6218956d 100644 --- a/cli/tools/jupyter/server.rs +++ b/cli/tools/jupyter/server.rs @@ -396,6 +396,7 @@ impl JupyterServer { .with_content(json!({ "status": "ok", "execution_count": self.execution_count, + // FIXME: also include user_expressions })) .send(connection) .await?; -- cgit v1.2.3