From d137501a639cb315772866f6775fcd9f43e28f5b Mon Sep 17 00:00:00 2001 From: Levente Kurusa Date: Sat, 22 Apr 2023 13:20:00 +0200 Subject: feat(node/http): implement ClientRequest.setTimeout() (#18783) - implement setTimeout with matching semantics of Node - add the test from Node but leave it turned off because ClientRequest has no underlying socket --- cli/tests/node_compat/config.jsonc | 3 +++ 1 file changed, 3 insertions(+) (limited to 'cli') diff --git a/cli/tests/node_compat/config.jsonc b/cli/tests/node_compat/config.jsonc index ddbdf458f..ce1cf3a08 100644 --- a/cli/tests/node_compat/config.jsonc +++ b/cli/tests/node_compat/config.jsonc @@ -351,6 +351,9 @@ "test-http-agent-getname.js", "test-http-client-get-url.js", "test-http-client-read-in-error.js", + // TODO(lev): ClientRequest.socket is not polyfilled so this test keeps + // failing + //"test-http-client-set-timeout.js", "test-http-localaddress.js", "test-http-outgoing-buffer.js", "test-http-outgoing-internal-headernames-getter.js", -- cgit v1.2.3