From cba5ae45c2422a4cf9df3a149a646a191a8f27b2 Mon Sep 17 00:00:00 2001 From: Trevor Manz Date: Fri, 6 Oct 2023 16:31:12 -0400 Subject: fix(jupyter): Rename logo assets so they are discoverable (#20806) Changes logo prefix from `icon-*` to `logo-*` so they are correctly discovered by Jupyter. --- cli/tools/jupyter/install.rs | 6 ++++-- cli/tools/jupyter/resources/deno-logo-svg.svg | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) create mode 100644 cli/tools/jupyter/resources/deno-logo-svg.svg (limited to 'cli') diff --git a/cli/tools/jupyter/install.rs b/cli/tools/jupyter/install.rs index d1777d92d..d1e4ef46b 100644 --- a/cli/tools/jupyter/install.rs +++ b/cli/tools/jupyter/install.rs @@ -12,6 +12,7 @@ use tempfile::TempDir; const DENO_ICON_32: &[u8] = include_bytes!("./resources/deno-logo-32x32.png"); const DENO_ICON_64: &[u8] = include_bytes!("./resources/deno-logo-64x64.png"); +const DENO_ICON_SVG: &[u8] = include_bytes!("./resources/deno-logo-svg.svg"); pub fn status() -> Result<(), AnyError> { let output = std::process::Command::new("jupyter") @@ -61,8 +62,9 @@ pub fn install() -> Result<(), AnyError> { let f = std::fs::File::create(kernel_json_path)?; serde_json::to_writer_pretty(f, &json_data)?; - install_icon(temp_dir.path(), "icon-32x32.png", DENO_ICON_32)?; - install_icon(temp_dir.path(), "icon-64x64.png", DENO_ICON_64)?; + install_icon(temp_dir.path(), "logo-32x32.png", DENO_ICON_32)?; + install_icon(temp_dir.path(), "logo-64x64.png", DENO_ICON_64)?; + install_icon(temp_dir.path(), "logo-svg.svg", DENO_ICON_SVG)?; let child_result = std::process::Command::new("jupyter") .args([ diff --git a/cli/tools/jupyter/resources/deno-logo-svg.svg b/cli/tools/jupyter/resources/deno-logo-svg.svg new file mode 100644 index 000000000..d7bb9ef80 --- /dev/null +++ b/cli/tools/jupyter/resources/deno-logo-svg.svg @@ -0,0 +1 @@ + -- cgit v1.2.3