From cb3a3a1e951d0eef9e2d095f87eaaa2f5ea160ad Mon Sep 17 00:00:00 2001
From: Casper Beyer <caspervonb@pm.me>
Date: Wed, 7 Oct 2020 16:24:15 +0800
Subject: refactor(cli/inspector): use &str for post_message (#7851)

This changes the signature of InspectorSession.post_message to take a
&str rather than a String avoiding the need call str.to_string at each
call site.
---
 cli/coverage.rs  | 28 ++++++++--------------------
 cli/inspector.rs |  2 +-
 cli/repl.rs      |  2 +-
 3 files changed, 10 insertions(+), 22 deletions(-)

(limited to 'cli')

diff --git a/cli/coverage.rs b/cli/coverage.rs
index e44f025bf..97344b589 100644
--- a/cli/coverage.rs
+++ b/cli/coverage.rs
@@ -20,20 +20,14 @@ impl CoverageCollector {
   }
 
   pub async fn start_collecting(&mut self) -> Result<(), AnyError> {
-    self
-      .session
-      .post_message("Debugger.enable".to_string(), None)
-      .await?;
+    self.session.post_message("Debugger.enable", None).await?;
 
-    self
-      .session
-      .post_message("Profiler.enable".to_string(), None)
-      .await?;
+    self.session.post_message("Profiler.enable", None).await?;
 
     self
       .session
       .post_message(
-        "Profiler.startPreciseCoverage".to_string(),
+        "Profiler.startPreciseCoverage",
         Some(json!({"callCount": true, "detailed": true})),
       )
       .await?;
@@ -44,7 +38,7 @@ impl CoverageCollector {
   pub async fn collect(&mut self) -> Result<Vec<Coverage>, AnyError> {
     let result = self
       .session
-      .post_message("Profiler.takePreciseCoverage".to_string(), None)
+      .post_message("Profiler.takePreciseCoverage", None)
       .await?;
 
     let take_coverage_result: TakePreciseCoverageResult =
@@ -55,7 +49,7 @@ impl CoverageCollector {
       let result = self
         .session
         .post_message(
-          "Debugger.getScriptSource".to_string(),
+          "Debugger.getScriptSource",
           Some(json!({
               "scriptId": script_coverage.script_id,
           })),
@@ -77,16 +71,10 @@ impl CoverageCollector {
   pub async fn stop_collecting(&mut self) -> Result<(), AnyError> {
     self
       .session
-      .post_message("Profiler.stopPreciseCoverage".to_string(), None)
-      .await?;
-    self
-      .session
-      .post_message("Profiler.disable".to_string(), None)
-      .await?;
-    self
-      .session
-      .post_message("Debugger.disable".to_string(), None)
+      .post_message("Profiler.stopPreciseCoverage", None)
       .await?;
+    self.session.post_message("Profiler.disable", None).await?;
+    self.session.post_message("Debugger.disable", None).await?;
 
     Ok(())
   }
diff --git a/cli/inspector.rs b/cli/inspector.rs
index 171be512b..4a6fe7a14 100644
--- a/cli/inspector.rs
+++ b/cli/inspector.rs
@@ -901,7 +901,7 @@ impl InspectorSession {
 
   pub async fn post_message(
     &mut self,
-    method: String,
+    method: &str,
     params: Option<serde_json::Value>,
   ) -> Result<serde_json::Value, AnyError> {
     let id = self.next_message_id;
diff --git a/cli/repl.rs b/cli/repl.rs
index d07815d41..fbc37fac5 100644
--- a/cli/repl.rs
+++ b/cli/repl.rs
@@ -38,7 +38,7 @@ async fn post_message_and_poll(
   method: &str,
   params: Option<Value>,
 ) -> Result<Value, AnyError> {
-  let response = session.post_message(method.to_string(), params);
+  let response = session.post_message(method, params);
   tokio::pin!(response);
 
   loop {
-- 
cgit v1.2.3