From 8df47882c942d3cf5558fee05f02629025e46ae7 Mon Sep 17 00:00:00 2001 From: Nayeem Rahman Date: Thu, 7 Mar 2024 17:27:24 +0000 Subject: fix(lsp): don't apply renames to remote modules (#22765) --- cli/lsp/tsc.rs | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to 'cli') diff --git a/cli/lsp/tsc.rs b/cli/lsp/tsc.rs index ce848c210..104024167 100644 --- a/cli/lsp/tsc.rs +++ b/cli/lsp/tsc.rs @@ -2115,8 +2115,13 @@ impl RenameLocations { LspClientUrl, lsp::TextDocumentEdit, > = HashMap::new(); + let mut includes_non_files = false; for location in self.locations.iter() { let specifier = resolve_url(&location.document_span.file_name)?; + if specifier.scheme() != "file" { + includes_non_files = true; + continue; + } let uri = language_server.url_map.normalize_specifier(&specifier)?; let asset_or_doc = language_server.get_asset_or_document(&specifier)?; @@ -2146,6 +2151,10 @@ impl RenameLocations { })); } + if includes_non_files { + language_server.client.show_message(lsp::MessageType::WARNING, "The renamed symbol had references in non-file schemed modules. These have not been modified."); + } + Ok(lsp::WorkspaceEdit { change_annotations: None, changes: None, -- cgit v1.2.3