From 871a0c9c0ea72aa95eb83e2e9010bdc05403f7d4 Mon Sep 17 00:00:00 2001 From: Yiyu Lin Date: Sat, 16 May 2020 03:26:16 +0800 Subject: fix some clippy warning (#5462) --- cli/ops/fs.rs | 12 ++++++------ cli/swc_util.rs | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) (limited to 'cli') diff --git a/cli/ops/fs.rs b/cli/ops/fs.rs index 573058d70..116366c8d 100644 --- a/cli/ops/fs.rs +++ b/cli/ops/fs.rs @@ -833,9 +833,9 @@ fn op_make_temp_dir( // We can't assume that paths are always valid utf8 strings. let path = make_temp( // Converting Option to Option<&str> - dir.as_ref().map(|x| &**x), - prefix.as_ref().map(|x| &**x), - suffix.as_ref().map(|x| &**x), + dir.as_deref(), + prefix.as_deref(), + suffix.as_deref(), true, )?; let path_str = into_string(path.into_os_string())?; @@ -864,9 +864,9 @@ fn op_make_temp_file( // We can't assume that paths are always valid utf8 strings. let path = make_temp( // Converting Option to Option<&str> - dir.as_ref().map(|x| &**x), - prefix.as_ref().map(|x| &**x), - suffix.as_ref().map(|x| &**x), + dir.as_deref(), + prefix.as_deref(), + suffix.as_deref(), false, )?; let path_str = into_string(path.into_os_string())?; diff --git a/cli/swc_util.rs b/cli/swc_util.rs index a2e5d50fd..f579cbd36 100644 --- a/cli/swc_util.rs +++ b/cli/swc_util.rs @@ -161,7 +161,7 @@ impl AstParser { self .comments .take_leading_comments(span.lo()) - .unwrap_or_else(|| vec![]) + .unwrap_or_else(Vec::new) } } -- cgit v1.2.3