From 7e4ee02e2e37db8adfaf4a05aba3819838904650 Mon Sep 17 00:00:00 2001 From: Matt Mastracci Date: Mon, 15 Apr 2024 14:10:09 -0600 Subject: fix(ext/io): Fix NUL termination error in windows named pipes (#23379) Due to a terminating NUL that was placed in a `r#` string, we were not actually NUL-terminating pipe names on Windows. While this has no security implications due to the random nature of the prefix, it would occasionally cause random failures when the trailing garbage would make the pipe name invalid. --- cli/tools/test/mod.rs | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) (limited to 'cli') diff --git a/cli/tools/test/mod.rs b/cli/tools/test/mod.rs index 2a406e560..f48827117 100644 --- a/cli/tools/test/mod.rs +++ b/cli/tools/test/mod.rs @@ -1346,18 +1346,8 @@ async fn test_specifiers( }) }); - // TODO(mmastrac): Temporarily limit concurrency in windows testing to avoid named pipe issue: - // *** Unexpected server pipe failure '"\\\\.\\pipe\\deno_pipe_e30f45c9df61b1e4.1198.222\\0"': 3 - // This is likely because we're hitting some sort of invisible resource limit - // This limit is both in cli/lsp/testing/execution.rs and cli/tools/test/mod.rs - let concurrent = if cfg!(windows) { - std::cmp::min(concurrent_jobs.get(), 4) - } else { - concurrent_jobs.get() - }; - let join_stream = stream::iter(join_handles) - .buffer_unordered(concurrent) + .buffer_unordered(concurrent_jobs.get()) .collect::, tokio::task::JoinError>>>(); let handler = spawn(async move { report_tests(receiver, reporter).await.0 }); -- cgit v1.2.3