From 560ad0331bf99a2564f53201cd086ff902901bfe Mon Sep 17 00:00:00 2001 From: David Sherret Date: Mon, 9 Sep 2024 17:35:41 -0400 Subject: fix(node/byonm): do not accidentally resolve bare node built-ins (#25543) This was accidentally enabled in byonm, but it requires the `--unstable-bare-node-builtins` flag. Closes #25358 --- cli/resolver.rs | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) (limited to 'cli') diff --git a/cli/resolver.rs b/cli/resolver.rs index 5b657b895..07cb6931d 100644 --- a/cli/resolver.rs +++ b/cli/resolver.rs @@ -707,7 +707,14 @@ impl Resolver for CliGraphResolver { .resolve_if_for_npm_pkg(raw_specifier, referrer, to_node_mode(mode)) .map_err(ResolveError::Other)?; if let Some(res) = maybe_resolution { - return Ok(res.into_url()); + match res { + NodeResolution::Esm(url) | NodeResolution::CommonJs(url) => { + return Ok(url) + } + NodeResolution::BuiltIn(_) => { + // don't resolve bare specifiers for built-in modules via node resolution + } + } } } -- cgit v1.2.3