From 34dac6c6efa75f38c29031a65db1ee3332a67259 Mon Sep 17 00:00:00 2001 From: Nayeem Rahman Date: Sat, 3 Jun 2023 21:22:32 +0100 Subject: refactor(core): remove force_op_registration and cleanup JsRuntimeForSnapshot (#19353) Addresses https://github.com/denoland/deno/pull/19308#discussion_r1212248194. Removes force_op_registration as it is no longer necessary. --- cli/lsp/tsc.rs | 3 --- cli/ops/bench.rs | 3 --- cli/ops/mod.rs | 3 --- cli/ops/testing.rs | 3 --- cli/tsc/mod.rs | 11 +---------- 5 files changed, 1 insertion(+), 22 deletions(-) (limited to 'cli') diff --git a/cli/lsp/tsc.rs b/cli/lsp/tsc.rs index bfbb5cf9a..0e52f8d87 100644 --- a/cli/lsp/tsc.rs +++ b/cli/lsp/tsc.rs @@ -3261,9 +3261,6 @@ deno_core::extension!(deno_tsc, options.performance, )); }, - customizer = |ext: &mut deno_core::ExtensionBuilder| { - ext.force_op_registration(); - }, ); /// Instruct a language server runtime to start the language server and provide diff --git a/cli/ops/bench.rs b/cli/ops/bench.rs index da0f3d959..f569a8cbb 100644 --- a/cli/ops/bench.rs +++ b/cli/ops/bench.rs @@ -42,9 +42,6 @@ deno_core::extension!(deno_bench, state.put(options.sender); state.put(BenchContainer::default()); }, - customizer = |ext: &mut deno_core::ExtensionBuilder| { - ext.force_op_registration(); - }, ); #[derive(Clone)] diff --git a/cli/ops/mod.rs b/cli/ops/mod.rs index d39f19270..5066c44b9 100644 --- a/cli/ops/mod.rs +++ b/cli/ops/mod.rs @@ -23,9 +23,6 @@ deno_core::extension!(deno_cli, state = |state, options| { state.put(options.npm_resolver); }, - customizer = |ext: &mut deno_core::ExtensionBuilder| { - ext.force_op_registration(); - }, ); #[op] diff --git a/cli/ops/testing.rs b/cli/ops/testing.rs index 3f9ade7c9..b4d9b451a 100644 --- a/cli/ops/testing.rs +++ b/cli/ops/testing.rs @@ -43,9 +43,6 @@ deno_core::extension!(deno_test, state.put(options.sender); state.put(TestContainer::default()); }, - customizer = |ext: &mut deno_core::ExtensionBuilder| { - ext.force_op_registration(); - }, ); #[derive(Clone)] diff --git a/cli/tsc/mod.rs b/cli/tsc/mod.rs index 2b8a210ab..d9f9b8b53 100644 --- a/cli/tsc/mod.rs +++ b/cli/tsc/mod.rs @@ -117,13 +117,7 @@ pub fn get_types_declaration_file_text(unstable: bool) -> String { } fn get_asset_texts_from_new_runtime() -> Result, AnyError> { - deno_core::extension!( - deno_cli_tsc, - ops_fn = deno_ops, - customizer = |ext: &mut deno_core::ExtensionBuilder| { - ext.force_op_registration(); - }, - ); + deno_core::extension!(deno_cli_tsc, ops_fn = deno_ops); // the assets are stored within the typescript isolate, so take them out of there let mut runtime = JsRuntime::new(RuntimeOptions { @@ -780,9 +774,6 @@ pub fn exec(request: Request) -> Result { .unwrap(), )); }, - customizer = |ext: &mut deno_core::ExtensionBuilder| { - ext.force_op_registration(); - }, ); let startup_source = ascii_str!("globalThis.startup({ legacyFlag: false })"); -- cgit v1.2.3