From 224cff7a2f1de9cc821c34ccac63cc9e4ef17531 Mon Sep 17 00:00:00 2001 From: Ryan Dahl Date: Mon, 13 Mar 2023 08:58:17 -0400 Subject: Revert "feat(core): prevent isolate drop for CLI main worker (#18059)" (#18157) Fixes https://github.com/denoland/deno/issues/18120 https://github.com/denoland/deno/issues/18137 https://github.com/denoland/fresh/issues/1073 This reverts commit 0cce9c2bcc9667935a571d30847e66ef5d01a196. --- cli/standalone.rs | 1 - cli/worker.rs | 2 -- 2 files changed, 3 deletions(-) (limited to 'cli') diff --git a/cli/standalone.rs b/cli/standalone.rs index 6d2c7551a..ecf295924 100644 --- a/cli/standalone.rs +++ b/cli/standalone.rs @@ -301,7 +301,6 @@ pub async fn run( shared_array_buffer_store: None, compiled_wasm_module_store: None, stdio: Default::default(), - leak_isolate: true, }; let mut worker = MainWorker::bootstrap_from_options( main_module.clone(), diff --git a/cli/worker.rs b/cli/worker.rs index 33352a2d7..97794caf3 100644 --- a/cli/worker.rs +++ b/cli/worker.rs @@ -548,7 +548,6 @@ async fn create_main_worker_internal( shared_array_buffer_store: Some(ps.shared_array_buffer_store.clone()), compiled_wasm_module_store: Some(ps.compiled_wasm_module_store.clone()), stdio, - leak_isolate: !bench_or_test && ps.options.coverage_dir().is_none(), }; let mut worker = MainWorker::bootstrap_from_options( @@ -778,7 +777,6 @@ mod tests { shared_array_buffer_store: None, compiled_wasm_module_store: None, stdio: Default::default(), - leak_isolate: false, }; MainWorker::bootstrap_from_options(main_module, permissions, options) -- cgit v1.2.3