From f7c298e2972e6a1eb8f9329272ed8e8c9549266c Mon Sep 17 00:00:00 2001 From: Ryan Dahl Date: Mon, 26 Apr 2021 13:28:38 -0400 Subject: Remove denort optimization (#10350) denort is an optimization to "deno compile" to produce slightly smaller output. It's a decent idea, but causes a lot of negative side-effects: - Deno's link time is a source of constant agony both locally and in CI, denort doubles link time. - The release process is a long and arduous undertaking with many manual steps. denort necessitates an additional manual zip + upload from M1 apple computers. - The "deno compile" interface is complicated with the "--lite" option. This is confusing for uses ("why wouldn't you want lite?"). The benefits of this feature do not outweigh the negatives. We must find a different approach to optimizing "deno compile" output. --- cli/version.rs | 2 -- 1 file changed, 2 deletions(-) (limited to 'cli/version.rs') diff --git a/cli/version.rs b/cli/version.rs index 6fe7da070..8d82f5130 100644 --- a/cli/version.rs +++ b/cli/version.rs @@ -10,8 +10,6 @@ pub fn deno() -> String { }) } -// allow(dead_code) because denort does not use this. -#[allow(dead_code)] pub fn is_canary() -> bool { option_env!("DENO_CANARY").is_some() } -- cgit v1.2.3