From 9b2b8df927ac23cfa99016a684179f2a3198ba2e Mon Sep 17 00:00:00 2001 From: Divy Srivastava Date: Thu, 1 Dec 2022 21:29:15 -0800 Subject: feat(ops): Fast zero copy string arguments (#16777) Uses SeqOneByteString optimization to do zero-copy `&str` arguments in fast calls. - [x] Depends on https://github.com/denoland/rusty_v8/pull/1129 - [x] Depends on https://chromium-review.googlesource.com/c/v8/v8/+/4036884 - [x] Disable in async ops - [x] Make it work with owned `String` with an extra alloc in fast path. - [x] Support `Cow<'_, str>`. Owned for slow case, Borrowed for fast case ```rust #[op] fn op_string_len(s: &str) -> u32 { str.len() as u32 } ``` --- cli/tsc/mod.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'cli/tsc') diff --git a/cli/tsc/mod.rs b/cli/tsc/mod.rs index a8eb15c19..1fb4d32d3 100644 --- a/cli/tsc/mod.rs +++ b/cli/tsc/mod.rs @@ -683,9 +683,9 @@ pub fn resolve_npm_package_reference_types( } #[op] -fn op_is_node_file(state: &mut OpState, path: String) -> bool { +fn op_is_node_file(state: &mut OpState, path: &str) -> bool { let state = state.borrow::(); - match ModuleSpecifier::parse(&path) { + match ModuleSpecifier::parse(path) { Ok(specifier) => state .maybe_npm_resolver .as_ref() -- cgit v1.2.3