From 319f6074761421b797db71bf10f6171516e3d92a Mon Sep 17 00:00:00 2001
From: Yiyu Lin <linyiyu1992@gmail.com>
Date: Wed, 4 Jan 2023 20:20:36 +0800
Subject: chore(cli,ext,rt): remove some unnecessary `clone` or `malloc`
 (#17261)

---
 cli/tsc/diagnostics.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'cli/tsc')

diff --git a/cli/tsc/diagnostics.rs b/cli/tsc/diagnostics.rs
index 4cd6564cb..fb7304c9b 100644
--- a/cli/tsc/diagnostics.rs
+++ b/cli/tsc/diagnostics.rs
@@ -340,9 +340,9 @@ impl Diagnostics {
   /// returns `true` are included.
   pub fn filter<P>(&self, predicate: P) -> Self
   where
-    P: FnMut(&Diagnostic) -> bool,
+    P: FnMut(&Diagnostic) -> Option<Diagnostic>,
   {
-    let diagnostics = self.0.clone().into_iter().filter(predicate).collect();
+    let diagnostics = self.0.iter().filter_map(predicate).collect();
     Self(diagnostics)
   }
 
-- 
cgit v1.2.3