From e1fe31508c471eeb7c30916abd780b3930f7e42b Mon Sep 17 00:00:00 2001 From: Nayeem Rahman Date: Sun, 27 Aug 2023 10:16:09 +0100 Subject: fix(lsp/testing): use full ancestry to compute static id of step (#20297) Fixes https://github.com/denoland/vscode_deno/issues/656. Test steps were ID'd by a checksum of `[origin, level, step_name]` which is incorrect. Now it's `[origin, ...ancestor_names, step_name]`. --- cli/tools/test/mod.rs | 10 ---------- 1 file changed, 10 deletions(-) (limited to 'cli/tools') diff --git a/cli/tools/test/mod.rs b/cli/tools/test/mod.rs index 9ad205e2e..2a0938e96 100644 --- a/cli/tools/test/mod.rs +++ b/cli/tools/test/mod.rs @@ -297,16 +297,6 @@ pub struct TestStepDescription { pub root_name: String, } -impl TestStepDescription { - pub fn static_id(&self) -> String { - checksum::gen(&[ - self.location.file_name.as_bytes(), - &self.level.to_be_bytes(), - self.name.as_bytes(), - ]) - } -} - #[allow(clippy::derive_partial_eq_without_eq)] #[derive(Debug, Clone, PartialEq, Deserialize)] #[serde(rename_all = "camelCase")] -- cgit v1.2.3