From 72fe9bb47005e720444e65a66e91559287137780 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Wed, 8 Mar 2023 07:44:54 -0400 Subject: refactor: rename InternalModuleLoader to ExtModuleLoader, use ext: scheme for snapshotted modules (#18041) This commit renames "deno_core::InternalModuleLoader" to "ExtModuleLoader" and changes the specifiers used by the modules loaded from this loader to "ext:". "internal:" scheme was really ambiguous and it's more characters than "ext:", which should result in slightly smaller snapshot size. Closes https://github.com/denoland/deno/issues/18020 --- cli/tools/coverage/mod.rs | 2 +- cli/tools/test.rs | 6 ++---- 2 files changed, 3 insertions(+), 5 deletions(-) (limited to 'cli/tools') diff --git a/cli/tools/coverage/mod.rs b/cli/tools/coverage/mod.rs index 1bd2779bf..c7a4d58da 100644 --- a/cli/tools/coverage/mod.rs +++ b/cli/tools/coverage/mod.rs @@ -594,7 +594,7 @@ fn filter_coverages( coverages .into_iter() .filter(|e| { - let is_internal = e.url.starts_with("internal:") + let is_internal = e.url.starts_with("ext:") || e.url.ends_with("__anonymous__") || e.url.ends_with("$deno$test.js") || e.url.ends_with(".snap"); diff --git a/cli/tools/test.rs b/cli/tools/test.rs index 6468da249..9ca806fb0 100644 --- a/cli/tools/test.rs +++ b/cli/tools/test.rs @@ -655,8 +655,7 @@ fn abbreviate_test_error(js_error: &JsError) -> JsError { // check if there are any stack frames coming from user code let should_filter = frames.iter().any(|f| { if let Some(file_name) = &f.file_name { - !(file_name.starts_with("[internal:") - || file_name.starts_with("internal:")) + !(file_name.starts_with("[ext:") || file_name.starts_with("ext:")) } else { true } @@ -668,8 +667,7 @@ fn abbreviate_test_error(js_error: &JsError) -> JsError { .rev() .skip_while(|f| { if let Some(file_name) = &f.file_name { - file_name.starts_with("[internal:") - || file_name.starts_with("internal:") + file_name.starts_with("[ext:") || file_name.starts_with("ext:") } else { false } -- cgit v1.2.3