From 275dee60e71225a9c6c4b3b4ea7ffe4c6ecb4d87 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= <biwanczuk@gmail.com>
Date: Thu, 23 Mar 2023 23:27:58 +0100
Subject: refactor: make version and user_agent &'static str (#18400)

These caused a bunch of unnecessary allocations on each startup.
---
 cli/tools/upgrade.rs | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

(limited to 'cli/tools')

diff --git a/cli/tools/upgrade.rs b/cli/tools/upgrade.rs
index 7ce9e77b9..933dad095 100644
--- a/cli/tools/upgrade.rs
+++ b/cli/tools/upgrade.rs
@@ -226,7 +226,7 @@ pub fn check_for_upgrades(http_client: HttpClient, cache_file_path: PathBuf) {
           "{}",
           colors::italic_gray("Run `deno upgrade` to install it.")
         );
-        print_release_notes(&version::deno(), &upgrade_version);
+        print_release_notes(version::deno(), &upgrade_version);
       }
 
       update_checker.store_prompted();
@@ -330,7 +330,7 @@ pub async fn upgrade(
         let latest_hash = latest_version.clone();
         crate::version::GIT_COMMIT_HASH == latest_hash
       } else if !crate::version::is_canary() {
-        let current = Version::parse_standard(&crate::version::deno()).unwrap();
+        let current = Version::parse_standard(crate::version::deno()).unwrap();
         let latest = Version::parse_standard(&latest_version).unwrap();
         current >= latest
       } else {
@@ -344,7 +344,7 @@ pub async fn upgrade(
         log::info!(
           "Local deno version {} is the most recent release",
           if upgrade_flags.canary {
-            crate::version::GIT_COMMIT_HASH.to_string()
+            crate::version::GIT_COMMIT_HASH
           } else {
             crate::version::deno()
           }
@@ -388,7 +388,7 @@ pub async fn upgrade(
     fs::remove_file(&new_exe_path)?;
     log::info!("Upgraded successfully (dry run)");
     if !upgrade_flags.canary {
-      print_release_notes(&version::deno(), &install_version);
+      print_release_notes(version::deno(), &install_version);
     }
   } else {
     let output_exe_path =
@@ -422,7 +422,7 @@ pub async fn upgrade(
     }
     log::info!("Upgraded successfully");
     if !upgrade_flags.canary {
-      print_release_notes(&version::deno(), &install_version);
+      print_release_notes(version::deno(), &install_version);
     }
   }
 
-- 
cgit v1.2.3