From 0bd53fd52d8937afed401fe1c61bb2ba0b23501c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Thu, 28 Sep 2023 16:51:44 +0200 Subject: fix(jupyter): more robust Deno.jupyter namespace (#20710) --- cli/tools/jupyter/server.rs | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) (limited to 'cli/tools/jupyter/server.rs') diff --git a/cli/tools/jupyter/server.rs b/cli/tools/jupyter/server.rs index c54dcd275..2489fcd04 100644 --- a/cli/tools/jupyter/server.rs +++ b/cli/tools/jupyter/server.rs @@ -391,15 +391,18 @@ impl JupyterServer { let output = get_jupyter_display_or_eval_value(&mut self.repl_session, &result) .await?; - msg - .new_message("execute_result") - .with_content(json!({ - "execution_count": self.execution_count, - "data": output, - "metadata": {}, - })) - .send(&mut *self.iopub_socket.lock().await) - .await?; + // Don't bother sending `execute_result` reply if the MIME bundle is empty + if !output.is_empty() { + msg + .new_message("execute_result") + .with_content(json!({ + "execution_count": self.execution_count, + "data": output, + "metadata": {}, + })) + .send(&mut *self.iopub_socket.lock().await) + .await?; + } msg .new_reply() .with_content(json!({ -- cgit v1.2.3