From fb021d7ceff3f8b1d7cdb0c2bdd75ea07c0428d2 Mon Sep 17 00:00:00 2001 From: David Sherret Date: Wed, 15 Mar 2023 17:46:36 -0400 Subject: refactor: remove usages of `map_or` / `map_or_else` (#18212) These methods are confusing because the arguments are backwards. I feel like they should have never been added to `Option` and that clippy should suggest rewriting to `map(...).unwrap_or(...)`/`map(...).unwrap_or_else(|| ...)` https://github.com/rust-lang/rfcs/issues/1025 --- cli/tools/coverage/mod.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'cli/tools/coverage/mod.rs') diff --git a/cli/tools/coverage/mod.rs b/cli/tools/coverage/mod.rs index 05ad853f8..eaa087171 100644 --- a/cli/tools/coverage/mod.rs +++ b/cli/tools/coverage/mod.rs @@ -562,7 +562,10 @@ fn collect_coverages( ) -> Result, AnyError> { let mut coverages: Vec = Vec::new(); let file_paths = FileCollector::new(|file_path| { - file_path.extension().map_or(false, |ext| ext == "json") + file_path + .extension() + .map(|ext| ext == "json") + .unwrap_or(false) }) .ignore_git_folder() .ignore_node_modules() -- cgit v1.2.3