From a080acc1b46ce9915760ce5c818763c64be8dca1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Mon, 15 Apr 2024 19:08:33 +0100 Subject: refactor: move lifecycle events dispatch to Rust (#23358) This commit moves logic of dispatching lifecycle events ( "load", "beforeunload", "unload") to be triggered from Rust. Before that we were executing scripts from Rust, but now we are storing references to functions from "99_main.js" and calling them directly. Prerequisite for https://github.com/denoland/deno/issues/23342 --- cli/tools/bench/mod.rs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'cli/tools/bench') diff --git a/cli/tools/bench/mod.rs b/cli/tools/bench/mod.rs index 8663fbbc8..88bff479c 100644 --- a/cli/tools/bench/mod.rs +++ b/cli/tools/bench/mod.rs @@ -26,7 +26,6 @@ use deno_core::error::JsError; use deno_core::futures::future; use deno_core::futures::stream; use deno_core::futures::StreamExt; -use deno_core::located_script_name; use deno_core::serde_v8; use deno_core::unsync::spawn; use deno_core::unsync::spawn_blocking; @@ -220,7 +219,7 @@ async fn bench_specifier_inner( // Ensure that there are no pending exceptions before we start running tests worker.run_up_to_duration(Duration::from_millis(0)).await?; - worker.dispatch_load_event(located_script_name!())?; + worker.dispatch_load_event()?; let benchmarks = { let state_rc = worker.js_runtime.op_state(); @@ -269,8 +268,8 @@ async fn bench_specifier_inner( // Ignore `defaultPrevented` of the `beforeunload` event. We don't allow the // event loop to continue beyond what's needed to await results. - worker.dispatch_beforeunload_event(located_script_name!())?; - worker.dispatch_unload_event(located_script_name!())?; + worker.dispatch_beforeunload_event()?; + worker.dispatch_unload_event()?; // Ensure the worker has settled so we can catch any remaining unhandled rejections. We don't // want to wait forever here. -- cgit v1.2.3