From 3d8a4d3b81e107bbb152ad69047f64d16ca800f3 Mon Sep 17 00:00:00 2001 From: Nayeem Rahman Date: Wed, 26 Apr 2023 21:23:28 +0100 Subject: feat(cli): don't check permissions for statically analyzable dynamic imports (#18713) Closes #17697 Closes #17658 --- cli/tools/bench.rs | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'cli/tools/bench.rs') diff --git a/cli/tools/bench.rs b/cli/tools/bench.rs index 9930bcc77..962b1ac17 100644 --- a/cli/tools/bench.rs +++ b/cli/tools/bench.rs @@ -418,7 +418,6 @@ impl BenchReporter for ConsoleReporter { /// Type check a collection of module and document specifiers. async fn check_specifiers( ps: &ProcState, - permissions: Permissions, specifiers: Vec, ) -> Result<(), AnyError> { let lib = ps.options.ts_type_lib_window(); @@ -428,10 +427,8 @@ async fn check_specifiers( false, lib, PermissionsContainer::allow_all(), - PermissionsContainer::new(permissions), ) .await?; - Ok(()) } @@ -654,7 +651,7 @@ pub async fn run_benchmarks( return Err(generic_error("No bench modules found")); } - check_specifiers(&ps, permissions.clone(), specifiers.clone()).await?; + check_specifiers(&ps, specifiers.clone()).await?; if bench_options.no_run { return Ok(()); @@ -813,7 +810,7 @@ pub async fn run_benchmarks_with_watch( .filter(|specifier| modules_to_reload.contains(specifier)) .collect::>(); - check_specifiers(&ps, permissions.clone(), specifiers.clone()).await?; + check_specifiers(&ps, specifiers.clone()).await?; if bench_options.no_run { return Ok(()); -- cgit v1.2.3