From ff0daa2b9d8a149d36173e19ce8dc169921486c7 Mon Sep 17 00:00:00 2001 From: Marvin Hagemeister Date: Thu, 18 May 2023 21:42:27 +0200 Subject: fix(npm): `process` not defined in readline (#19184) Issue was that we create node globals much later, so pulling `process` via a module import is the way to go. Fixes #19183 --- cli/tests/unit_node/readline_test.ts | 13 +++++++++++++ 1 file changed, 13 insertions(+) (limited to 'cli/tests') diff --git a/cli/tests/unit_node/readline_test.ts b/cli/tests/unit_node/readline_test.ts index bef9008dd..914d23e4a 100644 --- a/cli/tests/unit_node/readline_test.ts +++ b/cli/tests/unit_node/readline_test.ts @@ -12,3 +12,16 @@ Deno.test("[node/readline] createInstance", () => { // deno-lint-ignore no-explicit-any assertInstanceOf(rl, Interface as any); }); + +// Test for https://github.com/denoland/deno/issues/19183 +Deno.test("[node/readline] don't throw on rl.question()", () => { + const rli = createInterface({ + input: new Readable({ read() {} }), + output: new Writable({ write() {} }), + terminal: true, + }); + + // Calling this would throw + rli.question("foo", () => rli.close()); + rli.close(); +}); -- cgit v1.2.3