From fb04e87387e04053bf41a1512b4850adf62202c6 Mon Sep 17 00:00:00 2001 From: David Sherret Date: Sun, 27 Nov 2022 13:25:08 -0500 Subject: fix(npm): ensure npm package downloaded once per run when using `--reload` (#16842) --- cli/tests/npm_tests.rs | 7 +++++++ cli/tests/testdata/npm/dynamic_import_reload_same_package/main.out | 5 +++++ cli/tests/testdata/npm/dynamic_import_reload_same_package/main.ts | 7 +++++++ cli/tests/testdata/npm/dynamic_import_reload_same_package/other.ts | 3 +++ 4 files changed, 22 insertions(+) create mode 100644 cli/tests/testdata/npm/dynamic_import_reload_same_package/main.out create mode 100644 cli/tests/testdata/npm/dynamic_import_reload_same_package/main.ts create mode 100644 cli/tests/testdata/npm/dynamic_import_reload_same_package/other.ts (limited to 'cli/tests') diff --git a/cli/tests/npm_tests.rs b/cli/tests/npm_tests.rs index 99e475620..3939ee7be 100644 --- a/cli/tests/npm_tests.rs +++ b/cli/tests/npm_tests.rs @@ -155,6 +155,13 @@ mod npm { // http_server: true, // }); + itest!(dynamic_import_reload_same_package { + args: "run -A --reload npm/dynamic_import_reload_same_package/main.ts", + output: "npm/dynamic_import_reload_same_package/main.out", + envs: env_vars(), + http_server: true, + }); + itest!(env_var_re_export_dev { args: "run --allow-read --allow-env --quiet npm/env_var_re_export/main.js", output_str: Some("dev\n"), diff --git a/cli/tests/testdata/npm/dynamic_import_reload_same_package/main.out b/cli/tests/testdata/npm/dynamic_import_reload_same_package/main.out new file mode 100644 index 000000000..918e7f5e8 --- /dev/null +++ b/cli/tests/testdata/npm/dynamic_import_reload_same_package/main.out @@ -0,0 +1,5 @@ +Download http://localhost:4545/npm/registry/chalk +Download http://localhost:4545/npm/registry/chalk/chalk-5.0.1.tgz +Starting... +Ran other. +Finished... diff --git a/cli/tests/testdata/npm/dynamic_import_reload_same_package/main.ts b/cli/tests/testdata/npm/dynamic_import_reload_same_package/main.ts new file mode 100644 index 000000000..7c7ee7d55 --- /dev/null +++ b/cli/tests/testdata/npm/dynamic_import_reload_same_package/main.ts @@ -0,0 +1,7 @@ +import chalk from "npm:chalk@5"; + +console.log(chalk.green("Starting...")); +// non-analyzable +const importName = "./other.ts"; +await import(importName); +console.log(chalk.green("Finished...")); diff --git a/cli/tests/testdata/npm/dynamic_import_reload_same_package/other.ts b/cli/tests/testdata/npm/dynamic_import_reload_same_package/other.ts new file mode 100644 index 000000000..28e3da14f --- /dev/null +++ b/cli/tests/testdata/npm/dynamic_import_reload_same_package/other.ts @@ -0,0 +1,3 @@ +import chalk from "npm:chalk@5"; + +console.log(chalk.green("Ran other.")); -- cgit v1.2.3