From d76acfdc17e27b53fc53e6cd3051ff0acaefef42 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Tue, 17 May 2022 16:59:35 +0200 Subject: fix: base64 encoding of source maps with emojis (#14607) This commit fixes source maps for files that contain emojis. This is done by updating "deno_ast" to "0.14.1" for the case of "--no-check" flag (ie using SWC emit) and by overriding TSC's default base64 encoder (which turned out to be buggy) for the type checking case. --- cli/tests/testdata/coverage/complex.ts | 3 +++ cli/tests/testdata/coverage/complex_expected.lcov | 5 +++-- cli/tests/testdata/coverage/complex_expected.out | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) (limited to 'cli/tests') diff --git a/cli/tests/testdata/coverage/complex.ts b/cli/tests/testdata/coverage/complex.ts index 47d4ffa79..d128b5437 100644 --- a/cli/tests/testdata/coverage/complex.ts +++ b/cli/tests/testdata/coverage/complex.ts @@ -69,3 +69,6 @@ export function ƒ(): number { // This arrow function should also show up as uncovered. console.log("%s", () => 1); + +// Make sure emojis work properly +console.log("📣❓"); diff --git a/cli/tests/testdata/coverage/complex_expected.lcov b/cli/tests/testdata/coverage/complex_expected.lcov index a0af4cff3..1bb79d277 100644 --- a/cli/tests/testdata/coverage/complex_expected.lcov +++ b/cli/tests/testdata/coverage/complex_expected.lcov @@ -48,6 +48,7 @@ DA:66,0 DA:67,0 DA:68,1 DA:71,0 -LH:22 -LF:37 +DA:74,1 +LH:23 +LF:38 end_of_record diff --git a/cli/tests/testdata/coverage/complex_expected.out b/cli/tests/testdata/coverage/complex_expected.out index e9f9a453f..e318e2067 100644 --- a/cli/tests/testdata/coverage/complex_expected.out +++ b/cli/tests/testdata/coverage/complex_expected.out @@ -1,4 +1,4 @@ -cover [WILDCARD]/coverage/complex.ts ... 59.459% (22/37) +cover [WILDCARD]/coverage/complex.ts ... 60.526% (23/38) 46 | export function unused( 47 | foo: string, 48 | bar: string, -- cgit v1.2.3