From b03f4a4a1c252d808b72fc462ea783362f810c75 Mon Sep 17 00:00:00 2001 From: Kitson Kelly Date: Tue, 27 Oct 2020 06:56:00 +1100 Subject: fix(cli): restore permission check on workers (#8123) Fixes #8120 --- cli/tests/error_worker_permissions_local.ts | 4 ++++ cli/tests/error_worker_permissions_local.ts.out | 3 +++ cli/tests/error_worker_permissions_remote.ts | 4 ++++ cli/tests/error_worker_permissions_remote.ts.out | 3 +++ cli/tests/integration_tests.rs | 13 +++++++++++++ 5 files changed, 27 insertions(+) create mode 100644 cli/tests/error_worker_permissions_local.ts create mode 100644 cli/tests/error_worker_permissions_local.ts.out create mode 100644 cli/tests/error_worker_permissions_remote.ts create mode 100644 cli/tests/error_worker_permissions_remote.ts.out (limited to 'cli/tests') diff --git a/cli/tests/error_worker_permissions_local.ts b/cli/tests/error_worker_permissions_local.ts new file mode 100644 index 000000000..b43c8fe94 --- /dev/null +++ b/cli/tests/error_worker_permissions_local.ts @@ -0,0 +1,4 @@ +new Worker( + new URL("./subdeb/worker_types.ts", import.meta.url).toString(), + { type: "module" }, +); diff --git a/cli/tests/error_worker_permissions_local.ts.out b/cli/tests/error_worker_permissions_local.ts.out new file mode 100644 index 000000000..e53accbab --- /dev/null +++ b/cli/tests/error_worker_permissions_local.ts.out @@ -0,0 +1,3 @@ +[WILDCARD] +error: Uncaught (in worker "") read access to "[WILDCARD]worker_types.ts", run again with the --allow-read flag +[WILDCARD] diff --git a/cli/tests/error_worker_permissions_remote.ts b/cli/tests/error_worker_permissions_remote.ts new file mode 100644 index 000000000..9fd1ba5a8 --- /dev/null +++ b/cli/tests/error_worker_permissions_remote.ts @@ -0,0 +1,4 @@ +new Worker( + "http://localhost:4545/cli/tests/subdir/worker_types.ts", + { type: "module" }, +); diff --git a/cli/tests/error_worker_permissions_remote.ts.out b/cli/tests/error_worker_permissions_remote.ts.out new file mode 100644 index 000000000..6cf63fa22 --- /dev/null +++ b/cli/tests/error_worker_permissions_remote.ts.out @@ -0,0 +1,3 @@ +[WILDCARD] +error: Uncaught (in worker "") network access to "http://localhost:4545/cli/tests/subdir/worker_types.ts", run again with the --allow-net flag +[WILDCARD] diff --git a/cli/tests/integration_tests.rs b/cli/tests/integration_tests.rs index e637db07a..5a6bdae14 100644 --- a/cli/tests/integration_tests.rs +++ b/cli/tests/integration_tests.rs @@ -2467,6 +2467,19 @@ itest!(error_local_static_import_from_remote_js { output: "error_local_static_import_from_remote.js.out", }); +itest!(error_worker_permissions_local { + args: "run --reload error_worker_permissions_local.ts", + output: "error_worker_permissions_local.ts.out", + exit_code: 1, +}); + +itest!(error_worker_permissions_remote { + args: "run --reload error_worker_permissions_remote.ts", + http_server: true, + output: "error_worker_permissions_remote.ts.out", + exit_code: 1, +}); + itest!(exit_error42 { exit_code: 42, args: "run --quiet --reload exit_error42.ts", -- cgit v1.2.3