From ae81065c758a540aa61639e51372c1e254d92c9a Mon Sep 17 00:00:00 2001 From: Luca Casonato Date: Mon, 9 Oct 2023 12:43:14 +0900 Subject: fix(ext/http): Deno.Server should not be thenable (#20723) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Otherwise you can not return `Deno.Server` from async functions. Co-authored-by: Yoshiya Hinosawa Co-authored-by: Bartek Iwańczuk --- cli/tests/unit/serve_test.ts | 11 +++++++++++ 1 file changed, 11 insertions(+) (limited to 'cli/tests') diff --git a/cli/tests/unit/serve_test.ts b/cli/tests/unit/serve_test.ts index 6f58db006..2e560af99 100644 --- a/cli/tests/unit/serve_test.ts +++ b/cli/tests/unit/serve_test.ts @@ -3717,6 +3717,17 @@ async function curlRequestWithStdErr(args: string[]) { return [new TextDecoder().decode(stdout), new TextDecoder().decode(stderr)]; } +Deno.test("Deno.Server is not thenable", async () => { + // deno-lint-ignore require-await + async function serveTest() { + const server = Deno.serve({ port: servePort }, (_) => new Response("")); + assert(!("then" in server)); + return server; + } + const server = await serveTest(); + await server.shutdown(); +}); + Deno.test( { ignore: Deno.build.os === "windows", -- cgit v1.2.3