From 91decbfabf6eec32486cbed124607bdf567d5e4a Mon Sep 17 00:00:00 2001 From: Kitson Kelly Date: Wed, 19 May 2021 22:28:23 +1000 Subject: fix(#10695): deps diagnostics include data property (#10696) Fixes #10695 --- cli/tests/integration_tests_lsp.rs | 17 ++++++++++++----- cli/tests/lsp/diagnostics_deno_deps.json | 25 +++++++++++++++++++++++++ 2 files changed, 37 insertions(+), 5 deletions(-) create mode 100644 cli/tests/lsp/diagnostics_deno_deps.json (limited to 'cli/tests') diff --git a/cli/tests/integration_tests_lsp.rs b/cli/tests/integration_tests_lsp.rs index d08da622f..ad41afada 100644 --- a/cli/tests/integration_tests_lsp.rs +++ b/cli/tests/integration_tests_lsp.rs @@ -1362,17 +1362,24 @@ fn lsp_code_actions() { #[test] fn lsp_code_actions_deno_cache() { let mut client = init("initialize_params.json"); - did_open( - &mut client, - json!({ + client + .write_notification("textDocument/didOpen", json!({ "textDocument": { "uri": "file:///a/file.ts", "languageId": "typescript", "version": 1, "text": "import * as a from \"https://deno.land/x/a/mod.ts\";\n\nconsole.log(a);\n" } - }), - ); + })) + .unwrap(); + let (method, _) = client.read_notification::().unwrap(); + assert_eq!(method, "textDocument/publishDiagnostics"); + let (method, _) = client.read_notification::().unwrap(); + assert_eq!(method, "textDocument/publishDiagnostics"); + let (method, params) = client.read_notification().unwrap(); + assert_eq!(method, "textDocument/publishDiagnostics"); + assert_eq!(params, Some(load_fixture("diagnostics_deno_deps.json"))); + let (maybe_res, maybe_err) = client .write_request( "textDocument/codeAction", diff --git a/cli/tests/lsp/diagnostics_deno_deps.json b/cli/tests/lsp/diagnostics_deno_deps.json new file mode 100644 index 000000000..ec6cc4f51 --- /dev/null +++ b/cli/tests/lsp/diagnostics_deno_deps.json @@ -0,0 +1,25 @@ +{ + "uri": "file:///a/file.ts", + "diagnostics": [ + { + "range": { + "start": { + "line": 0, + "character": 19 + }, + "end": { + "line": 0, + "character": 49 + } + }, + "severity": 1, + "code": "no-cache", + "source": "deno", + "message": "Uncached or missing remote URL: \"https://deno.land/x/a/mod.ts\".", + "data": { + "specifier": "https://deno.land/x/a/mod.ts" + } + } + ], + "version": 1 +} -- cgit v1.2.3