From 9010b8df53cd37f0410e08c43a194667974686a2 Mon Sep 17 00:00:00 2001 From: Matt Mastracci Date: Thu, 9 Nov 2023 13:57:26 -0700 Subject: perf: remove knowledge of promise IDs from deno (#21132) We can move all promise ID knowledge to deno_core, allowing us to better experiment with promise implementation in deno_core. `{un,}refOpPromise(promise)` is equivalent to `{un,}refOp(promise[promiseIdSymbol])` --- cli/tests/unit/ref_unref_test.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'cli/tests') diff --git a/cli/tests/unit/ref_unref_test.ts b/cli/tests/unit/ref_unref_test.ts index eea93b165..656636d0c 100644 --- a/cli/tests/unit/ref_unref_test.ts +++ b/cli/tests/unit/ref_unref_test.ts @@ -2,11 +2,11 @@ import { assertNotEquals, execCode } from "./test_util.ts"; -Deno.test("[unrefOp] unref'ing invalid ops does not have effects", async () => { +Deno.test("[unrefOpPromise] unref'ing invalid ops does not have effects", async () => { const [statusCode, _] = await execCode(` - Deno[Deno.internal].core.unrefOp(-1); + Deno[Deno.internal].core.unrefOpPromise(new Promise(r => null)); setTimeout(() => { throw new Error() }, 10) `); - // Invalid unrefOp call doesn't affect exit condition of event loop + // Invalid unrefOpPromise call doesn't affect exit condition of event loop assertNotEquals(statusCode, 0); }); -- cgit v1.2.3