From 8e1b2fca59d71d2e6ab404238d7b38975adb3665 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Mon, 3 Oct 2022 17:45:01 +0200 Subject: fix(npm): panic on invalid package name (#16123) --- cli/tests/integration/npm_tests.rs | 7 +++++++ cli/tests/testdata/npm/invalid_package_name/main.js | 1 + cli/tests/testdata/npm/invalid_package_name/main.out | 2 ++ 3 files changed, 10 insertions(+) create mode 100644 cli/tests/testdata/npm/invalid_package_name/main.js create mode 100644 cli/tests/testdata/npm/invalid_package_name/main.out (limited to 'cli/tests') diff --git a/cli/tests/integration/npm_tests.rs b/cli/tests/integration/npm_tests.rs index d111bd76e..32ec12656 100644 --- a/cli/tests/integration/npm_tests.rs +++ b/cli/tests/integration/npm_tests.rs @@ -181,6 +181,13 @@ itest!(nonexistent_file { exit_code: 1, }); +itest!(invalid_package_name { + args: "run --unstable -A --quiet npm/invalid_package_name/main.js", + output: "npm/invalid_package_name/main.out", + envs: env_vars(), + exit_code: 1, +}); + itest!(require_json { args: "run --unstable -A --quiet npm/require_json/main.js", output: "npm/require_json/main.out", diff --git a/cli/tests/testdata/npm/invalid_package_name/main.js b/cli/tests/testdata/npm/invalid_package_name/main.js new file mode 100644 index 000000000..1e3783054 --- /dev/null +++ b/cli/tests/testdata/npm/invalid_package_name/main.js @@ -0,0 +1 @@ +import * as foo from "npm:@foo"; diff --git a/cli/tests/testdata/npm/invalid_package_name/main.out b/cli/tests/testdata/npm/invalid_package_name/main.out new file mode 100644 index 000000000..7d2b3754d --- /dev/null +++ b/cli/tests/testdata/npm/invalid_package_name/main.out @@ -0,0 +1,2 @@ +error: Not a valid package: @foo + at [WILDCARD]/invalid_package_name/main.js:1:22 -- cgit v1.2.3