From 841f215fd4eb2211e30b09e8d01596777c868050 Mon Sep 17 00:00:00 2001 From: Kenta Moriuchi Date: Wed, 1 Nov 2023 16:06:25 +0900 Subject: fix(ext/node): adapt dynamic type checking to Node.js behavior (#21014) --- cli/tests/unit_node/util_test.ts | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'cli/tests') diff --git a/cli/tests/unit_node/util_test.ts b/cli/tests/unit_node/util_test.ts index 81794c856..64020141a 100644 --- a/cli/tests/unit_node/util_test.ts +++ b/cli/tests/unit_node/util_test.ts @@ -46,8 +46,8 @@ Deno.test({ name: "[util] isBoolean", fn() { assert(util.isBoolean(true)); - assert(util.isBoolean(new Boolean())); - assert(util.isBoolean(new Boolean(true))); + assert(!util.isBoolean(new Boolean())); + assert(!util.isBoolean(new Boolean(true))); assert(util.isBoolean(false)); assert(!util.isBoolean("deno")); assert(!util.isBoolean("true")); @@ -80,7 +80,7 @@ Deno.test({ name: "[util] isNumber", fn() { assert(util.isNumber(666)); - assert(util.isNumber(new Number(666))); + assert(!util.isNumber(new Number(666))); assert(!util.isNumber("999")); assert(!util.isNumber(null)); }, @@ -90,7 +90,7 @@ Deno.test({ name: "[util] isString", fn() { assert(util.isString("deno")); - assert(util.isString(new String("DIO"))); + assert(!util.isString(new String("DIO"))); assert(!util.isString(1337)); }, }); @@ -99,6 +99,7 @@ Deno.test({ name: "[util] isSymbol", fn() { assert(util.isSymbol(Symbol())); + assert(!util.isSymbol(Object(Symbol()))); assert(!util.isSymbol(123)); assert(!util.isSymbol("string")); }, @@ -128,7 +129,7 @@ Deno.test({ name: "[util] isError", fn() { const java = new Error(); - const nodejs = new TypeError(); + const nodejs = Reflect.construct(Error, [], Object); const deno = "Future"; assert(util.isError(java)); assert(util.isError(nodejs)); -- cgit v1.2.3