From 75ca013f076f443dce3d38f31a168295351ed0e5 Mon Sep 17 00:00:00 2001 From: Nayeem Rahman Date: Sat, 18 Sep 2021 14:40:04 +0100 Subject: fix(cli/fmt_errors): Abbreviate long data URLs in stack traces (#12127) Co-authored-by: Mike White --- cli/tests/integration/run_tests.rs | 6 ++++++ cli/tests/testdata/import_data_url_error_stack.ts.out | 2 +- cli/tests/testdata/long_data_url_formatting.ts | 3 +++ cli/tests/testdata/long_data_url_formatting.ts.out | 8 ++++++++ 4 files changed, 18 insertions(+), 1 deletion(-) create mode 100644 cli/tests/testdata/long_data_url_formatting.ts create mode 100644 cli/tests/testdata/long_data_url_formatting.ts.out (limited to 'cli/tests') diff --git a/cli/tests/integration/run_tests.rs b/cli/tests/integration/run_tests.rs index 14e0e1241..04ba10b7b 100644 --- a/cli/tests/integration/run_tests.rs +++ b/cli/tests/integration/run_tests.rs @@ -1885,3 +1885,9 @@ itest!(dom_exception_formatting { output: "dom_exception_formatting.ts.out", exit_code: 1, }); + +itest!(long_data_url_formatting { + args: "run long_data_url_formatting.ts", + output: "long_data_url_formatting.ts.out", + exit_code: 1, +}); diff --git a/cli/tests/testdata/import_data_url_error_stack.ts.out b/cli/tests/testdata/import_data_url_error_stack.ts.out index d456ad0ea..ccd72e4ad 100644 --- a/cli/tests/testdata/import_data_url_error_stack.ts.out +++ b/cli/tests/testdata/import_data_url_error_stack.ts.out @@ -1,6 +1,6 @@ [WILDCARD]error: Uncaught Error: Hello 2 throw new Error(`Hello ${A.C}`); ^ - at a (data:application/typescript;base64,ZW51bSBBIHsKICBBLAogIEIsCiAgQywKIH0KIAogZXhwb3J0IGZ1bmN0aW9uIGEoKSB7CiAgIHRocm93IG5ldyBFcnJvcihgSGVsbG8gJHtBLkN9YCk7CiB9CiA=:8:10) + at a (data:application/typescript;base64,ZW51bSBBIHsKICBBLAog......JHtBLkN9YCk7CiB9CiA=:8:10) at file:///[WILDCARD]/import_data_url_error_stack.ts:3:1 [WILDCARD] diff --git a/cli/tests/testdata/long_data_url_formatting.ts b/cli/tests/testdata/long_data_url_formatting.ts new file mode 100644 index 000000000..2ed2d5a03 --- /dev/null +++ b/cli/tests/testdata/long_data_url_formatting.ts @@ -0,0 +1,3 @@ +await import( + 'data:application/typescript,console.trace("foo"); const error = new Error("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"); console.log(error.stack); throw error;' +); diff --git a/cli/tests/testdata/long_data_url_formatting.ts.out b/cli/tests/testdata/long_data_url_formatting.ts.out new file mode 100644 index 000000000..ea78c2591 --- /dev/null +++ b/cli/tests/testdata/long_data_url_formatting.ts.out @@ -0,0 +1,8 @@ +[WILDCARD]Trace: foo + at data:application/typescript,console.trace("foo")......stack); throw error;:1:9 +Error: aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa + at data:application/typescript,console.trace("foo")......stack); throw error;:1:37 +error: Uncaught (in promise) Error: aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +console.trace("foo"); const error = new Error("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"); console.log(error.stack); throw error; + ^ + at data:application/typescript,console.trace("foo")......stack); throw error;:1:37 -- cgit v1.2.3