From 6e2df8c64feb92653077a5494d2c64a9f6fd2f48 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Thu, 19 Mar 2020 00:25:55 +0100 Subject: feat: Deno.test() sanitizes ops and resources (#4399) This PR brings assertOps and assertResources sanitizers to Deno.test() API. assertOps checks that test doesn't leak async ops, ie. there are no unresolved promises originating from Deno APIs. Enabled by default, can be disabled using Deno.TestDefinition.disableOpSanitizer. assertResources checks that test doesn't leak resources, ie. all resources used in test are closed. For example; if a file is opened during a test case it must be explicitly closed before test case finishes. It's most useful for asynchronous generators. Enabled by default, can be disabled using Deno.TestDefinition.disableResourceSanitizer. We've used those sanitizers in internal runtime tests and it proved very useful in surfacing incorrect tests which resulted in interference between the tests. All tests have been sanitized. Closes #4208 --- cli/tests/workers_test.ts | 170 ++++++++++++++++++++++++++-------------------- 1 file changed, 95 insertions(+), 75 deletions(-) (limited to 'cli/tests') diff --git a/cli/tests/workers_test.ts b/cli/tests/workers_test.ts index 370b3cd1a..84eeabf12 100644 --- a/cli/tests/workers_test.ts +++ b/cli/tests/workers_test.ts @@ -27,87 +27,107 @@ export function createResolvable(): Resolvable { return Object.assign(promise, methods!) as Resolvable; } -Deno.test(async function workersBasic(): Promise { - const promise = createResolvable(); - const jsWorker = new Worker("../tests/subdir/test_worker.js", { - type: "module", - name: "jsWorker" - }); - const tsWorker = new Worker("../tests/subdir/test_worker.ts", { - type: "module", - name: "tsWorker" - }); - - tsWorker.onmessage = (e): void => { - assertEquals(e.data, "Hello World"); - promise.resolve(); - }; +Deno.test({ + name: "workersBasic", + // FIXME(bartlomieju): + disableOpSanitizer: true, + fn: async function(): Promise { + const promise = createResolvable(); + const jsWorker = new Worker("../tests/subdir/test_worker.js", { + type: "module", + name: "jsWorker" + }); + const tsWorker = new Worker("../tests/subdir/test_worker.ts", { + type: "module", + name: "tsWorker" + }); + + tsWorker.onmessage = (e): void => { + assertEquals(e.data, "Hello World"); + promise.resolve(); + }; + + jsWorker.onmessage = (e): void => { + assertEquals(e.data, "Hello World"); + tsWorker.postMessage("Hello World"); + }; + + jsWorker.onerror = (e: Event): void => { + e.preventDefault(); + jsWorker.postMessage("Hello World"); + }; - jsWorker.onmessage = (e): void => { - assertEquals(e.data, "Hello World"); - tsWorker.postMessage("Hello World"); - }; - - jsWorker.onerror = (e: Event): void => { - e.preventDefault(); jsWorker.postMessage("Hello World"); - }; - - jsWorker.postMessage("Hello World"); - await promise; + await promise; + } }); -Deno.test(async function nestedWorker(): Promise { - const promise = createResolvable(); - - const nestedWorker = new Worker("../tests/subdir/nested_worker.js", { - type: "module", - name: "nested" - }); - - nestedWorker.onmessage = (e): void => { - assert(e.data.type !== "error"); - promise.resolve(); - }; - - nestedWorker.postMessage("Hello World"); - await promise; +Deno.test({ + name: "nestedWorker", + // FIXME(bartlomieju): + disableOpSanitizer: true, + fn: async function(): Promise { + const promise = createResolvable(); + + const nestedWorker = new Worker("../tests/subdir/nested_worker.js", { + type: "module", + name: "nested" + }); + + nestedWorker.onmessage = (e): void => { + assert(e.data.type !== "error"); + promise.resolve(); + }; + + nestedWorker.postMessage("Hello World"); + await promise; + } }); -Deno.test(async function workerThrowsWhenExecuting(): Promise { - const promise = createResolvable(); - const throwingWorker = new Worker("../tests/subdir/throwing_worker.js", { - type: "module" - }); - - // eslint-disable-next-line @typescript-eslint/no-explicit-any - throwingWorker.onerror = (e: any): void => { - e.preventDefault(); - assert(/Uncaught Error: Thrown error/.test(e.message)); - promise.resolve(); - }; - - await promise; +Deno.test({ + name: "workerThrowsWhenExecuting", + // FIXME(bartlomieju): + disableOpSanitizer: true, + fn: async function(): Promise { + const promise = createResolvable(); + const throwingWorker = new Worker("../tests/subdir/throwing_worker.js", { + type: "module" + }); + + // eslint-disable-next-line @typescript-eslint/no-explicit-any + throwingWorker.onerror = (e: any): void => { + e.preventDefault(); + assert(/Uncaught Error: Thrown error/.test(e.message)); + promise.resolve(); + }; + + await promise; + } }); -Deno.test(async function workerCanUseFetch(): Promise { - const promise = createResolvable(); - - const fetchingWorker = new Worker("../tests/subdir/fetching_worker.js", { - type: "module" - }); - - // eslint-disable-next-line @typescript-eslint/no-explicit-any - fetchingWorker.onerror = (e: any): void => { - e.preventDefault(); - promise.reject(e.message); - }; - - // Defer promise.resolve() to allow worker to shut down - fetchingWorker.onmessage = (e): void => { - assert(e.data === "Done!"); - promise.resolve(); - }; - - await promise; +Deno.test({ + name: "workerCanUseFetch", + // FIXME(bartlomieju): + disableOpSanitizer: true, + fn: async function(): Promise { + const promise = createResolvable(); + + const fetchingWorker = new Worker("../tests/subdir/fetching_worker.js", { + type: "module" + }); + + // eslint-disable-next-line @typescript-eslint/no-explicit-any + fetchingWorker.onerror = (e: any): void => { + e.preventDefault(); + promise.reject(e.message); + }; + + // Defer promise.resolve() to allow worker to shut down + fetchingWorker.onmessage = (e): void => { + assert(e.data === "Done!"); + promise.resolve(); + }; + + await promise; + } }); -- cgit v1.2.3