From 6dd7a7ecd9d9b09f5112c73c67aa5f94480c8196 Mon Sep 17 00:00:00 2001 From: Nayeem Rahman Date: Tue, 1 Jun 2021 07:45:37 +0100 Subject: fix(cli): represent bare imports as module graph error slots (#10804) Fixes #10795 --- cli/tests/095_cache_with_bare_import.ts | 1 + cli/tests/095_cache_with_bare_import.ts.out | 1 + cli/tests/error_027_bare_import_error.ts | 1 - cli/tests/error_027_bare_import_error.ts.out | 8 -------- cli/tests/error_027_bundle_with_bare_import.ts | 1 + cli/tests/error_027_bundle_with_bare_import.ts.out | 1 + cli/tests/integration_tests.rs | 12 +++++++++--- 7 files changed, 13 insertions(+), 12 deletions(-) create mode 100644 cli/tests/095_cache_with_bare_import.ts create mode 100644 cli/tests/095_cache_with_bare_import.ts.out delete mode 100644 cli/tests/error_027_bare_import_error.ts delete mode 100644 cli/tests/error_027_bare_import_error.ts.out create mode 100644 cli/tests/error_027_bundle_with_bare_import.ts create mode 100644 cli/tests/error_027_bundle_with_bare_import.ts.out (limited to 'cli/tests') diff --git a/cli/tests/095_cache_with_bare_import.ts b/cli/tests/095_cache_with_bare_import.ts new file mode 100644 index 000000000..c0748305d --- /dev/null +++ b/cli/tests/095_cache_with_bare_import.ts @@ -0,0 +1 @@ +import "foo"; diff --git a/cli/tests/095_cache_with_bare_import.ts.out b/cli/tests/095_cache_with_bare_import.ts.out new file mode 100644 index 000000000..f424f4c3e --- /dev/null +++ b/cli/tests/095_cache_with_bare_import.ts.out @@ -0,0 +1 @@ +[WILDCARD]error: Relative import path "foo" not prefixed with / or ./ or ../ from "file:///[WILDCARD]/095_cache_with_bare_import.ts" diff --git a/cli/tests/error_027_bare_import_error.ts b/cli/tests/error_027_bare_import_error.ts deleted file mode 100644 index c0748305d..000000000 --- a/cli/tests/error_027_bare_import_error.ts +++ /dev/null @@ -1 +0,0 @@ -import "foo"; diff --git a/cli/tests/error_027_bare_import_error.ts.out b/cli/tests/error_027_bare_import_error.ts.out deleted file mode 100644 index b52873d89..000000000 --- a/cli/tests/error_027_bare_import_error.ts.out +++ /dev/null @@ -1,8 +0,0 @@ -[WILDCARD]error: Unable to output bundle during Graph::bundle(). - -Caused by: - 0: load_transformed failed - 1: failed to analyze module - 2: failed to resolve foo from - 3: The graph is missing a dependency. - Specifier: foo from file:///[WILDCARD]/error_027_bare_import_error.ts diff --git a/cli/tests/error_027_bundle_with_bare_import.ts b/cli/tests/error_027_bundle_with_bare_import.ts new file mode 100644 index 000000000..c0748305d --- /dev/null +++ b/cli/tests/error_027_bundle_with_bare_import.ts @@ -0,0 +1 @@ +import "foo"; diff --git a/cli/tests/error_027_bundle_with_bare_import.ts.out b/cli/tests/error_027_bundle_with_bare_import.ts.out new file mode 100644 index 000000000..3aa4a42a2 --- /dev/null +++ b/cli/tests/error_027_bundle_with_bare_import.ts.out @@ -0,0 +1 @@ +[WILDCARD]error: Relative import path "foo" not prefixed with / or ./ or ../ from "file:///[WILDCARD]/error_027_bundle_with_bare_import.ts" diff --git a/cli/tests/integration_tests.rs b/cli/tests/integration_tests.rs index 5af533dab..6c5626666 100644 --- a/cli/tests/integration_tests.rs +++ b/cli/tests/integration_tests.rs @@ -3139,6 +3139,12 @@ console.log("finish"); exit_code: 1, }); + itest!(_095_cache_with_bare_import { + args: "cache 095_cache_with_bare_import.ts", + output: "095_cache_with_bare_import.ts.out", + exit_code: 1, + }); + itest!(dynamic_import_permissions_remote_remote { args: "run --quiet --reload --allow-net=localhost:4545 dynamic_import/permissions_remote_remote.ts", output: "dynamic_import/permissions_remote_remote.ts.out", @@ -3481,9 +3487,9 @@ console.log("finish"); http_server: true, }); - itest!(error_027_bare_import_error { - args: "bundle error_027_bare_import_error.ts", - output: "error_027_bare_import_error.ts.out", + itest!(error_027_bundle_with_bare_import { + args: "bundle error_027_bundle_with_bare_import.ts", + output: "error_027_bundle_with_bare_import.ts.out", exit_code: 1, }); -- cgit v1.2.3