From 6bbefdff395072503677e3b11dd8cba7d59efa18 Mon Sep 17 00:00:00 2001
From: Kitson Kelly <me@kitsonkelly.com>
Date: Tue, 25 May 2021 12:34:01 +1000
Subject: feat(lsp): diagnostics for deno types and triple-slash refs (#10699)

Fixes #9823
---
 cli/tests/integration_tests_lsp.rs            |  45 ++++++++++++
 cli/tests/lsp/diagnostics_deno_types.json     | 101 ++++++++++++++++++++++++++
 cli/tests/lsp/did_open_params_deno_types.json |   8 ++
 3 files changed, 154 insertions(+)
 create mode 100644 cli/tests/lsp/diagnostics_deno_types.json
 create mode 100644 cli/tests/lsp/did_open_params_deno_types.json

(limited to 'cli/tests')

diff --git a/cli/tests/integration_tests_lsp.rs b/cli/tests/integration_tests_lsp.rs
index 76041c502..8e04cbb95 100644
--- a/cli/tests/integration_tests_lsp.rs
+++ b/cli/tests/integration_tests_lsp.rs
@@ -1398,6 +1398,11 @@ fn lsp_code_actions_deno_cache() {
       }
     }))
     .unwrap();
+  let (id, method, _) = client.read_request::<Value>().unwrap();
+  assert_eq!(method, "workspace/configuration");
+  client
+    .write_response(id, json!({ "enable": true }))
+    .unwrap();
   let (method, _) = client.read_notification::<Value>().unwrap();
   assert_eq!(method, "textDocument/publishDiagnostics");
   let (method, _) = client.read_notification::<Value>().unwrap();
@@ -1851,6 +1856,46 @@ fn lsp_diagnostics_warn() {
   shutdown(&mut client);
 }
 
+#[test]
+fn lsp_diagnostics_deno_types() {
+  let mut client = init("initialize_params.json");
+  client
+    .write_notification(
+      "textDocument/didOpen",
+      load_fixture("did_open_params_deno_types.json"),
+    )
+    .unwrap();
+  let (id, method, _) = client.read_request::<Value>().unwrap();
+  assert_eq!(method, "workspace/configuration");
+  client
+    .write_response(id, json!({ "enable": true }))
+    .unwrap();
+  let (maybe_res, maybe_err) = client
+    .write_request::<_, _, Value>(
+      "textDocument/documentSymbol",
+      json!({
+        "textDocument": {
+          "uri": "file:///a/file.ts"
+        }
+      }),
+    )
+    .unwrap();
+  assert!(maybe_res.is_some());
+  assert!(maybe_err.is_none());
+  let (method, _) = client.read_notification::<Value>().unwrap();
+  assert_eq!(method, "textDocument/publishDiagnostics");
+  let (method, _) = client.read_notification::<Value>().unwrap();
+  assert_eq!(method, "textDocument/publishDiagnostics");
+  let (method, maybe_params) = client
+    .read_notification::<lsp::PublishDiagnosticsParams>()
+    .unwrap();
+  assert_eq!(method, "textDocument/publishDiagnostics");
+  assert!(maybe_params.is_some());
+  let params = maybe_params.unwrap();
+  assert_eq!(params.diagnostics.len(), 5);
+  shutdown(&mut client);
+}
+
 #[derive(Deserialize)]
 #[serde(rename_all = "camelCase")]
 pub struct PerformanceAverage {
diff --git a/cli/tests/lsp/diagnostics_deno_types.json b/cli/tests/lsp/diagnostics_deno_types.json
new file mode 100644
index 000000000..f33945a59
--- /dev/null
+++ b/cli/tests/lsp/diagnostics_deno_types.json
@@ -0,0 +1,101 @@
+{
+  "uri": "file:///a/file.ts",
+  "diagnostics": [
+    {
+      "range": {
+        "start": {
+          "line": 0,
+          "character": 21
+        },
+        "end": {
+          "line": 0,
+          "character": 51
+        }
+      },
+      "severity": 1,
+      "code": "no-cache",
+      "source": "deno",
+      "message": "Uncached or missing remote URL: \"https://example.com/a/b.d.ts\".",
+      "data": {
+        "specifier": "https://example.com/a/b.d.ts"
+      }
+    },
+    {
+      "range": {
+        "start": {
+          "line": 7,
+          "character": 19
+        },
+        "end": {
+          "line": 7,
+          "character": 47
+        }
+      },
+      "severity": 1,
+      "code": "no-cache",
+      "source": "deno",
+      "message": "Uncached or missing remote URL: \"https://example.com/a/e.js\".",
+      "data": {
+        "specifier": "https://example.com/a/e.js"
+      }
+    },
+    {
+      "range": {
+        "start": {
+          "line": 6,
+          "character": 16
+        },
+        "end": {
+          "line": 6,
+          "character": 44
+        }
+      },
+      "severity": 1,
+      "code": "no-cache",
+      "source": "deno",
+      "message": "Uncached or missing remote URL: \"https://example.com/a/e.d.ts\".",
+      "data": {
+        "specifier": "https://example.com/a/e.d.ts"
+      }
+    },
+    {
+      "range": {
+        "start": {
+          "line": 4,
+          "character": 19
+        },
+        "end": {
+          "line": 4,
+          "character": 47
+        }
+      },
+      "severity": 1,
+      "code": "no-cache",
+      "source": "deno",
+      "message": "Uncached or missing remote URL: \"https://example.com/a/d.js\".",
+      "data": {
+        "specifier": "https://example.com/a/d.js"
+      }
+    },
+    {
+      "range": {
+        "start": {
+          "line": 3,
+          "character": 15
+        },
+        "end": {
+          "line": 3,
+          "character": 43
+        }
+      },
+      "severity": 1,
+      "code": "no-cache",
+      "source": "deno",
+      "message": "Uncached or missing remote URL: \"https://example.com/a/d.d.ts\".",
+      "data": {
+        "specifier": "https://example.com/a/d.d.ts"
+      }
+    }
+  ],
+  "version": 1
+}
diff --git a/cli/tests/lsp/did_open_params_deno_types.json b/cli/tests/lsp/did_open_params_deno_types.json
new file mode 100644
index 000000000..6f085d045
--- /dev/null
+++ b/cli/tests/lsp/did_open_params_deno_types.json
@@ -0,0 +1,8 @@
+{
+  "textDocument": {
+    "uri": "file:///a/file.ts",
+    "languageId": "typescript",
+    "version": 1,
+    "text": "/// <reference types=\"https://example.com/a/b.d.ts\" />\n/// <reference path=\"https://example.com/a/c.ts\"\n\n// @deno-types=https://example.com/a/d.d.ts\nimport * as d from \"https://example.com/a/d.js\";\n\n// @deno-types=\"https://example.com/a/e.d.ts\"\nimport * as e from \"https://example.com/a/e.js\";\n\nconsole.log(d, e);\n"
+  }
+}
-- 
cgit v1.2.3