From 3973ceb634afe7b4f38678efe0394da84d9c60a1 Mon Sep 17 00:00:00 2001 From: David Sherret Date: Mon, 5 Dec 2022 20:09:31 -0500 Subject: fix(npm): dependency types were sometimes not being resolved when package had no types entry (#16958) Closes #16957 --- .../npm/registry/@denotest/types-no-types-entry/1.0.0/dist/main.d.ts | 2 +- .../npm/registry/@denotest/types-no-types-entry/1.0.0/dist/main.js | 2 +- .../npm/registry/@denotest/types-no-types-entry/1.0.0/package.json | 5 ++++- cli/tests/testdata/npm/types_no_types_entry/main.out | 2 ++ 4 files changed, 8 insertions(+), 3 deletions(-) (limited to 'cli/tests') diff --git a/cli/tests/testdata/npm/registry/@denotest/types-no-types-entry/1.0.0/dist/main.d.ts b/cli/tests/testdata/npm/registry/@denotest/types-no-types-entry/1.0.0/dist/main.d.ts index 2341a14f0..8942f08dd 100644 --- a/cli/tests/testdata/npm/registry/@denotest/types-no-types-entry/1.0.0/dist/main.d.ts +++ b/cli/tests/testdata/npm/registry/@denotest/types-no-types-entry/1.0.0/dist/main.d.ts @@ -1 +1 @@ -export function getValue(): 5; +export { getValue } from "@denotest/types-entry-value-not-exists"; diff --git a/cli/tests/testdata/npm/registry/@denotest/types-no-types-entry/1.0.0/dist/main.js b/cli/tests/testdata/npm/registry/@denotest/types-no-types-entry/1.0.0/dist/main.js index d0c5dbc70..63c7ef0ce 100644 --- a/cli/tests/testdata/npm/registry/@denotest/types-no-types-entry/1.0.0/dist/main.js +++ b/cli/tests/testdata/npm/registry/@denotest/types-no-types-entry/1.0.0/dist/main.js @@ -1 +1 @@ -module.exports.getValue = () => 5; +module.exports.getValue = require("@denotest/types-entry-value-not-exists").getValue; diff --git a/cli/tests/testdata/npm/registry/@denotest/types-no-types-entry/1.0.0/package.json b/cli/tests/testdata/npm/registry/@denotest/types-no-types-entry/1.0.0/package.json index 377af2bae..6abccec98 100644 --- a/cli/tests/testdata/npm/registry/@denotest/types-no-types-entry/1.0.0/package.json +++ b/cli/tests/testdata/npm/registry/@denotest/types-no-types-entry/1.0.0/package.json @@ -1,5 +1,8 @@ { "name": "@denotest/types-no-types-entry", "version": "1.0.0", - "main": "./dist/main.js" + "main": "./dist/main.js", + "dependencies": { + "@denotest/types-entry-value-not-exists": "^1.0" + } } diff --git a/cli/tests/testdata/npm/types_no_types_entry/main.out b/cli/tests/testdata/npm/types_no_types_entry/main.out index 2aa78dd25..429940fff 100644 --- a/cli/tests/testdata/npm/types_no_types_entry/main.out +++ b/cli/tests/testdata/npm/types_no_types_entry/main.out @@ -1,4 +1,6 @@ Download http://localhost:4545/npm/registry/@denotest/types-no-types-entry +Download http://localhost:4545/npm/registry/@denotest/types-entry-value-not-exists +Download http://localhost:4545/npm/registry/@denotest/types-entry-value-not-exists/1.0.0.tgz Download http://localhost:4545/npm/registry/@denotest/types-no-types-entry/1.0.0.tgz Check file://[WILDCARD]/types_no_types_entry/main.ts error: TS2322 [ERROR]: Type 'number' is not assignable to type 'string'. -- cgit v1.2.3