From 1f9d158bdc212e8cb15b92039c9cd11884c9708c Mon Sep 17 00:00:00 2001 From: Nayeem Rahman Date: Sat, 29 Feb 2020 18:04:10 +0000 Subject: refactor(cli/js): Replace constructError() with getErrorClass() (#4189) Flattens dispatch error handling to produce one less useless stack frame on op errors. --- cli/tests/044_bad_resource.ts.out | 3 +-- cli/tests/error_004_missing_module.ts.out | 3 +-- cli/tests/error_005_missing_dynamic_import.ts.out | 3 +-- cli/tests/error_006_import_ext_failure.ts.out | 3 +-- cli/tests/error_011_bad_module_specifier.ts.out | 3 +-- cli/tests/error_012_bad_dynamic_import_specifier.ts.out | 3 +-- cli/tests/error_type_definitions.ts.out | 3 +-- 7 files changed, 7 insertions(+), 14 deletions(-) (limited to 'cli/tests') diff --git a/cli/tests/044_bad_resource.ts.out b/cli/tests/044_bad_resource.ts.out index 92b493ca9..681bed999 100644 --- a/cli/tests/044_bad_resource.ts.out +++ b/cli/tests/044_bad_resource.ts.out @@ -1,7 +1,6 @@ [WILDCARD] error: Uncaught BadResource: bad resource id -[WILDCARD]errors.ts:[WILDCARD] +[WILDCARD]dispatch_json.ts:[WILDCARD] at BadResource ([WILDCARD]errors.ts:[WILDCARD]) - at constructError ([WILDCARD]errors.ts:[WILDCARD]) at unwrapResponse ([WILDCARD]dispatch_json.ts:[WILDCARD]) at sendAsync ([WILDCARD]dispatch_json.ts:[WILDCARD]) diff --git a/cli/tests/error_004_missing_module.ts.out b/cli/tests/error_004_missing_module.ts.out index 492aef0e6..8e9f7f925 100644 --- a/cli/tests/error_004_missing_module.ts.out +++ b/cli/tests/error_004_missing_module.ts.out @@ -1,6 +1,5 @@ [WILDCARD]error: Uncaught NotFound: Cannot resolve module "[WILDCARD]/bad-module.ts" from "[WILDCARD]/error_004_missing_module.ts" -[WILDCARD]errors.ts:[WILDCARD] +[WILDCARD]dispatch_json.ts:[WILDCARD] at NotFound ([WILDCARD]errors.ts:[WILDCARD]) - at constructError ([WILDCARD]errors.ts:[WILDCARD]) at unwrapResponse ([WILDCARD]dispatch_json.ts:[WILDCARD]) at sendAsync[WILDCARD] ([WILDCARD]dispatch_json.ts:[WILDCARD]) diff --git a/cli/tests/error_005_missing_dynamic_import.ts.out b/cli/tests/error_005_missing_dynamic_import.ts.out index 3b48e4e78..7eb20fe04 100644 --- a/cli/tests/error_005_missing_dynamic_import.ts.out +++ b/cli/tests/error_005_missing_dynamic_import.ts.out @@ -1,6 +1,5 @@ [WILDCARD]error: Uncaught NotFound: Cannot resolve module "[WILDCARD]/bad-module.ts" from "[WILDCARD]/error_005_missing_dynamic_import.ts" -[WILDCARD]errors.ts:[WILDCARD] +[WILDCARD]dispatch_json.ts:[WILDCARD] at NotFound ([WILDCARD]errors.ts:[WILDCARD]) - at constructError ([WILDCARD]errors.ts:[WILDCARD]) at unwrapResponse ([WILDCARD]dispatch_json.ts:[WILDCARD]) at sendAsync[WILDCARD] ([WILDCARD]dispatch_json.ts:[WILDCARD]) diff --git a/cli/tests/error_006_import_ext_failure.ts.out b/cli/tests/error_006_import_ext_failure.ts.out index e113bc264..41b9b7bf8 100644 --- a/cli/tests/error_006_import_ext_failure.ts.out +++ b/cli/tests/error_006_import_ext_failure.ts.out @@ -1,6 +1,5 @@ [WILDCARD]error: Uncaught NotFound: Cannot resolve module "[WILDCARD]/non-existent" from "[WILDCARD]/error_006_import_ext_failure.ts" -[WILDCARD]errors.ts:[WILDCARD] +[WILDCARD]dispatch_json.ts:[WILDCARD] at NotFound ([WILDCARD]errors.ts:[WILDCARD]) - at constructError ([WILDCARD]errors.ts:[WILDCARD]) at unwrapResponse ([WILDCARD]dispatch_json.ts:[WILDCARD]) at sendAsync[WILDCARD] ([WILDCARD]dispatch_json.ts:[WILDCARD]) diff --git a/cli/tests/error_011_bad_module_specifier.ts.out b/cli/tests/error_011_bad_module_specifier.ts.out index 7bf7ef26a..054f05fd5 100644 --- a/cli/tests/error_011_bad_module_specifier.ts.out +++ b/cli/tests/error_011_bad_module_specifier.ts.out @@ -1,6 +1,5 @@ [WILDCARD]error: Uncaught URIError: relative import path "bad-module.ts" not prefixed with / or ./ or ../ Imported from "[WILDCARD]/error_011_bad_module_specifier.ts" -[WILDCARD]errors.ts:[WILDCARD] - at constructError ($deno$/errors.ts:[WILDCARD]) +[WILDCARD]dispatch_json.ts:[WILDCARD] at unwrapResponse ($deno$/dispatch_json.ts:[WILDCARD]) at sendSync ($deno$/dispatch_json.ts:[WILDCARD]) at resolveModules ($deno$/compiler_imports.ts:[WILDCARD]) diff --git a/cli/tests/error_012_bad_dynamic_import_specifier.ts.out b/cli/tests/error_012_bad_dynamic_import_specifier.ts.out index 9f41f9b28..1ac8f855f 100644 --- a/cli/tests/error_012_bad_dynamic_import_specifier.ts.out +++ b/cli/tests/error_012_bad_dynamic_import_specifier.ts.out @@ -1,6 +1,5 @@ [WILDCARD]error: Uncaught URIError: relative import path "bad-module.ts" not prefixed with / or ./ or ../ Imported from "[WILDCARD]/error_012_bad_dynamic_import_specifier.ts" -[WILDCARD]errors.ts:[WILDCARD] - at constructError ($deno$/errors.ts:[WILDCARD]) +[WILDCARD]dispatch_json.ts:[WILDCARD] at unwrapResponse ($deno$/dispatch_json.ts:[WILDCARD]) at sendSync ($deno$/dispatch_json.ts:[WILDCARD]) at resolveModules ($deno$/compiler_imports.ts:[WILDCARD]) diff --git a/cli/tests/error_type_definitions.ts.out b/cli/tests/error_type_definitions.ts.out index 04b012ead..90a3211e9 100644 --- a/cli/tests/error_type_definitions.ts.out +++ b/cli/tests/error_type_definitions.ts.out @@ -1,6 +1,5 @@ [WILDCARD]error: Uncaught URIError: relative import path "baz" not prefixed with / or ./ or ../ Imported from "[WILDCARD]/type_definitions/bar.d.ts" -[WILDCARD]errors.ts:[WILDCARD] - at constructError ($deno$/errors.ts:[WILDCARD]) +[WILDCARD]dispatch_json.ts:[WILDCARD] at unwrapResponse ($deno$/dispatch_json.ts:[WILDCARD]) at sendSync ($deno$/dispatch_json.ts:[WILDCARD]) at resolveModules ($deno$/compiler_imports.ts:[WILDCARD]) -- cgit v1.2.3