From 0f2121355f65baa27b530ef286c8b4ca0009fabf Mon Sep 17 00:00:00 2001 From: Nayeem Rahman Date: Thu, 4 Mar 2021 12:19:47 +0000 Subject: fix(runtime/web_worker): Don't block self.onmessage with TLA (#9619) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This commit rewrites implementation of "JsRuntime::mod_evaluate". Event loop is no longer polled automatically and users must manually drive event loop forward after calling "mod_evaluate". Co-authored-by: Nayeem Rahman Co-authored-by: Bartek IwaƄczuk --- cli/tests/workers/test.ts | 21 +++++++++++++++++++++ cli/tests/workers/worker_with_top_level_await.ts | 15 +++++++++++++++ 2 files changed, 36 insertions(+) create mode 100644 cli/tests/workers/worker_with_top_level_await.ts (limited to 'cli/tests') diff --git a/cli/tests/workers/test.ts b/cli/tests/workers/test.ts index 0888e01db..f411e434f 100644 --- a/cli/tests/workers/test.ts +++ b/cli/tests/workers/test.ts @@ -675,3 +675,24 @@ Deno.test({ w.terminate(); }, }); + +Deno.test({ + name: "Worker with top-level-await", + fn: async function (): Promise { + const result = deferred(); + const worker = new Worker( + new URL("worker_with_top_level_await.ts", import.meta.url).href, + { type: "module" }, + ); + worker.onmessage = (e): void => { + if (e.data == "ready") { + worker.postMessage("trigger worker handler"); + } else if (e.data == "triggered worker handler") { + result.resolve(); + } else { + result.reject(new Error("Handler didn't run during top-level delay.")); + } + }; + await result; + }, +}); diff --git a/cli/tests/workers/worker_with_top_level_await.ts b/cli/tests/workers/worker_with_top_level_await.ts new file mode 100644 index 000000000..6c5528900 --- /dev/null +++ b/cli/tests/workers/worker_with_top_level_await.ts @@ -0,0 +1,15 @@ +function delay(ms: number): Promise { + return new Promise((resolve) => { + setTimeout(() => { + resolve(); + }, ms); + }); +} + +onmessage = (e: MessageEvent) => { + postMessage("triggered worker handler"); + close(); +}; +postMessage("ready"); +await delay(1000); +postMessage("never"); -- cgit v1.2.3