From 160fe9787ee33c5cfda7218d4ca232345c7fa06e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= <biwanczuk@gmail.com>
Date: Fri, 26 May 2023 15:41:03 +0200
Subject: fix(node): make 'v8.setFlagsFromString' a noop (#19271)

Towards https://github.com/denoland/deno/issues/16460
---
 cli/tests/unit_node/v8_test.ts | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

(limited to 'cli/tests/unit_node/v8_test.ts')

diff --git a/cli/tests/unit_node/v8_test.ts b/cli/tests/unit_node/v8_test.ts
index ab1903596..724ac3504 100644
--- a/cli/tests/unit_node/v8_test.ts
+++ b/cli/tests/unit_node/v8_test.ts
@@ -4,10 +4,7 @@ import {
   getHeapStatistics,
   setFlagsFromString,
 } from "node:v8";
-import {
-  assertEquals,
-  assertThrows,
-} from "../../../test_util/std/testing/asserts.ts";
+import { assertEquals } from "../../../test_util/std/testing/asserts.ts";
 
 // https://github.com/nodejs/node/blob/a2bbe5ff216bc28f8dac1c36a8750025a93c3827/test/parallel/test-v8-version-tag.js#L6
 Deno.test({
@@ -51,8 +48,8 @@ Deno.test({
 });
 
 Deno.test({
-  name: "setFlagsFromString throws",
+  name: "setFlagsFromString",
   fn() {
-    assertThrows(() => setFlagsFromString("--allow_natives_syntax"));
+    setFlagsFromString("--allow_natives_syntax");
   },
 });
-- 
cgit v1.2.3