From 642c4a44a56ed02c2bf795bf04d7aebbc847e150 Mon Sep 17 00:00:00 2001
From: Divy Srivastava <dj.srivastava23@gmail.com>
Date: Tue, 2 Jan 2024 10:24:11 +0530
Subject: fix(ext/node): querystring stringify without encode callback (#21740)

Fixes https://github.com/denoland/deno/issues/21734

Changes:
- Use default encode when options do not provide a encode callback.
- Remove internal TS for `node:querystring`. Its not helping catching
bugs like this because of invalid type assumptions and use of `any`,
more of a maintenance burden.
---
 cli/tests/unit_node/querystring_test.ts | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

(limited to 'cli/tests/unit_node/querystring_test.ts')

diff --git a/cli/tests/unit_node/querystring_test.ts b/cli/tests/unit_node/querystring_test.ts
index d750bed95..ce2747db2 100644
--- a/cli/tests/unit_node/querystring_test.ts
+++ b/cli/tests/unit_node/querystring_test.ts
@@ -28,3 +28,24 @@ Deno.test({
     });
   },
 });
+
+// https://github.com/denoland/deno/issues/21734
+Deno.test({
+  name: "stringify options no encode",
+  fn() {
+    assertEquals(
+      stringify(
+        {
+          a: "hello",
+          b: 5,
+          c: true,
+          d: ["foo", "bar"],
+        },
+        "&",
+        "=",
+        {},
+      ),
+      "a=hello&b=5&c=true&d=foo&d=bar",
+    );
+  },
+});
-- 
cgit v1.2.3