From 78bfeebad11954666d3104ea3556ec9f2e64f6a4 Mon Sep 17 00:00:00 2001 From: Ryan Dahl Date: Fri, 5 Jun 2020 11:37:40 -0400 Subject: Revert "fix: Use # to denote line number in stack traces" (#6119) This reverts commit c4c6a8dae488a3473ee09b0e3a54943b706d8944 There is some controversy about this change because vscode doesn't interpret the fragments correctly. Needs more discussion before landing. --- cli/tests/unit/dispatch_json_test.ts | 6 +++--- cli/tests/unit/dispatch_minimal_test.ts | 6 +++--- cli/tests/unit/error_stack_test.ts | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) (limited to 'cli/tests/unit') diff --git a/cli/tests/unit/dispatch_json_test.ts b/cli/tests/unit/dispatch_json_test.ts index 51c63a4db..ebb8217e3 100644 --- a/cli/tests/unit/dispatch_json_test.ts +++ b/cli/tests/unit/dispatch_json_test.ts @@ -2,9 +2,9 @@ import { assert, unitTest, assertMatch, unreachable } from "./test_util.ts"; const openErrorStackPattern = new RegExp( `^.* - at unwrapResponse \\(.*dispatch_json\\.ts#.*\\) - at Object.sendAsync \\(.*dispatch_json\\.ts#.*\\) - at async Object\\.open \\(.*files\\.ts#.*\\).*$`, + at unwrapResponse \\(.*dispatch_json\\.ts:.*\\) + at Object.sendAsync \\(.*dispatch_json\\.ts:.*\\) + at async Object\\.open \\(.*files\\.ts:.*\\).*$`, "ms" ); diff --git a/cli/tests/unit/dispatch_minimal_test.ts b/cli/tests/unit/dispatch_minimal_test.ts index 98f482f73..12cf4595c 100644 --- a/cli/tests/unit/dispatch_minimal_test.ts +++ b/cli/tests/unit/dispatch_minimal_test.ts @@ -8,9 +8,9 @@ import { const readErrorStackPattern = new RegExp( `^.* - at unwrapResponse \\(.*dispatch_minimal\\.ts#.*\\) - at Object.sendAsyncMinimal \\(.*dispatch_minimal\\.ts#.*\\) - at async Object\\.read \\(.*io\\.ts#.*\\).*$`, + at unwrapResponse \\(.*dispatch_minimal\\.ts:.*\\) + at Object.sendAsyncMinimal \\(.*dispatch_minimal\\.ts:.*\\) + at async Object\\.read \\(.*io\\.ts:.*\\).*$`, "ms" ); diff --git a/cli/tests/unit/error_stack_test.ts b/cli/tests/unit/error_stack_test.ts index c3aed3886..052cb9591 100644 --- a/cli/tests/unit/error_stack_test.ts +++ b/cli/tests/unit/error_stack_test.ts @@ -93,7 +93,7 @@ unitTest(function prepareStackTrace(): void { getMockCallSite("CLI_SNAPSHOT.js", 23, 0), ]); assert(result.startsWith("Error: foo\n")); - assert(result.includes(".ts#"), "should remap to something in 'js/'"); + assert(result.includes(".ts:"), "should remap to something in 'js/'"); }); unitTest(function captureStackTrace(): void { -- cgit v1.2.3