From 3d65e57d7c48f5dd1307f83771fe5574d914cea3 Mon Sep 17 00:00:00 2001
From: Benjamin Gruenbaum <benjamingr@gmail.com>
Date: Sat, 14 Nov 2020 14:10:23 +0200
Subject: fix: fix various global objects constructor length (#8373)

This commit changes various Web APIs constructors to
match their signature in the browser.
---
 cli/tests/unit/globals_test.ts     | 4 ++++
 cli/tests/unit/performance_test.ts | 2 ++
 cli/tests/unit/permissions_test.ts | 8 +++++++-
 3 files changed, 13 insertions(+), 1 deletion(-)

(limited to 'cli/tests/unit')

diff --git a/cli/tests/unit/globals_test.ts b/cli/tests/unit/globals_test.ts
index 422bd2aec..4fd531b25 100644
--- a/cli/tests/unit/globals_test.ts
+++ b/cli/tests/unit/globals_test.ts
@@ -40,6 +40,10 @@ unitTest(function globalThisInstanceofWindow(): void {
   assert(globalThis instanceof Window);
 });
 
+unitTest(function globalThisConstructorLength(): void {
+  assert(globalThis.constructor.length === 0);
+});
+
 unitTest(function globalThisInstanceofEventTarget(): void {
   assert(globalThis instanceof EventTarget);
 });
diff --git a/cli/tests/unit/performance_test.ts b/cli/tests/unit/performance_test.ts
index 1df46b1b2..122938b36 100644
--- a/cli/tests/unit/performance_test.ts
+++ b/cli/tests/unit/performance_test.ts
@@ -83,10 +83,12 @@ unitTest(function performanceMeasure() {
 
 unitTest(function performanceIllegalConstructor() {
   assertThrows(() => new Performance(), TypeError, "Illegal constructor.");
+  assertEquals(Performance.length, 0);
 });
 
 unitTest(function performanceEntryIllegalConstructor() {
   assertThrows(() => new PerformanceEntry(), TypeError, "Illegal constructor.");
+  assertEquals(PerformanceEntry.length, 0);
 });
 
 unitTest(function performanceMeasureIllegalConstructor() {
diff --git a/cli/tests/unit/permissions_test.ts b/cli/tests/unit/permissions_test.ts
index eada8fe9a..dee8aa195 100644
--- a/cli/tests/unit/permissions_test.ts
+++ b/cli/tests/unit/permissions_test.ts
@@ -1,5 +1,10 @@
 // Copyright 2018-2020 the Deno authors. All rights reserved. MIT license.
-import { assertThrows, assertThrowsAsync, unitTest } from "./test_util.ts";
+import {
+  assertEquals,
+  assertThrows,
+  assertThrowsAsync,
+  unitTest,
+} from "./test_util.ts";
 
 unitTest(async function permissionInvalidName(): Promise<void> {
   await assertThrowsAsync(async () => {
@@ -24,4 +29,5 @@ unitTest(function permissionStatusIllegalConstructor() {
     TypeError,
     "Illegal constructor.",
   );
+  assertEquals(Deno.PermissionStatus.length, 0);
 });
-- 
cgit v1.2.3