From 397fec63d1bacabd2b8e48bd30a1727003a7a72b Mon Sep 17 00:00:00 2001 From: Yoshiya Hinosawa Date: Tue, 3 Nov 2020 02:58:29 +0900 Subject: fix(op_crates/web): fix URLSearchParams, malformed url handling (#8092) Co-authored-by: Evan --- cli/tests/unit/url_search_params_test.ts | 37 ++++++++++++++++++++++++++++---- 1 file changed, 33 insertions(+), 4 deletions(-) (limited to 'cli/tests/unit/url_search_params_test.ts') diff --git a/cli/tests/unit/url_search_params_test.ts b/cli/tests/unit/url_search_params_test.ts index 41b277129..dc0e8bd85 100644 --- a/cli/tests/unit/url_search_params_test.ts +++ b/cli/tests/unit/url_search_params_test.ts @@ -49,10 +49,39 @@ unitTest(function urlSearchParamsInitString(): void { }); unitTest(function urlSearchParamsInitStringWithPlusCharacter(): void { - const init = "q=a+b"; - const searchParams = new URLSearchParams(init); - assertEquals(searchParams.toString(), init); - assertEquals(searchParams.get("q"), "a b"); + let params = new URLSearchParams("q=a+b"); + assertEquals(params.toString(), "q=a+b"); + assertEquals(params.get("q"), "a b"); + + params = new URLSearchParams("q=a+b+c"); + assertEquals(params.toString(), "q=a+b+c"); + assertEquals(params.get("q"), "a b c"); +}); + +unitTest(function urlSearchParamsInitStringWithMalformedParams(): void { + // These test cases are copied from Web Platform Tests + // https://github.com/web-platform-tests/wpt/blob/54c6d64/url/urlsearchparams-constructor.any.js#L60-L80 + let params = new URLSearchParams("id=0&value=%"); + assert(params != null, "constructor returned non-null value."); + assert(params.has("id"), 'Search params object has name "id"'); + assert(params.has("value"), 'Search params object has name "value"'); + assertEquals(params.get("id"), "0"); + assertEquals(params.get("value"), "%"); + + params = new URLSearchParams("b=%2sf%2a"); + assert(params != null, "constructor returned non-null value."); + assert(params.has("b"), 'Search params object has name "b"'); + assertEquals(params.get("b"), "%2sf*"); + + params = new URLSearchParams("b=%2%2af%2a"); + assert(params != null, "constructor returned non-null value."); + assert(params.has("b"), 'Search params object has name "b"'); + assertEquals(params.get("b"), "%2*f*"); + + params = new URLSearchParams("b=%%2a"); + assert(params != null, "constructor returned non-null value."); + assert(params.has("b"), 'Search params object has name "b"'); + assertEquals(params.get("b"), "%*"); }); unitTest(function urlSearchParamsInitIterable(): void { -- cgit v1.2.3