From 668b400ff2fa5634f575e54f40ab1f0b78fcdf16 Mon Sep 17 00:00:00 2001 From: Feng Yu Date: Mon, 11 Oct 2021 21:21:18 +0800 Subject: feat(runtime): improve error messages of runtime fs (#11984) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This commit annotates errors returned from FS Deno APIs to include paths that were passed to the API calls. Co-authored-by: Bartek Iwańczuk --- cli/tests/unit/read_dir_test.ts | 30 ++++++++++++++++++++++++------ 1 file changed, 24 insertions(+), 6 deletions(-) (limited to 'cli/tests/unit/read_dir_test.ts') diff --git a/cli/tests/unit/read_dir_test.ts b/cli/tests/unit/read_dir_test.ts index ca900153a..686c38af3 100644 --- a/cli/tests/unit/read_dir_test.ts +++ b/cli/tests/unit/read_dir_test.ts @@ -40,15 +40,23 @@ unitTest({ permissions: { read: false } }, function readDirSyncPerm() { }); unitTest({ permissions: { read: true } }, function readDirSyncNotDir() { - assertThrows(() => { - Deno.readDirSync("cli/tests/testdata/fixture.json"); - }, Error); + assertThrows( + () => { + Deno.readDirSync("cli/tests/testdata/fixture.json"); + }, + Error, + `readdir 'cli/tests/testdata/fixture.json'`, + ); }); unitTest({ permissions: { read: true } }, function readDirSyncNotFound() { - assertThrows(() => { - Deno.readDirSync("bad_dir_name"); - }, Deno.errors.NotFound); + assertThrows( + () => { + Deno.readDirSync("bad_dir_name"); + }, + Deno.errors.NotFound, + `readdir 'bad_dir_name'`, + ); }); unitTest({ permissions: { read: true } }, async function readDirSuccess() { @@ -94,3 +102,13 @@ unitTest( } }, ); + +unitTest({ permissions: { read: true } }, async function readDirNotFound() { + await assertRejects( + async () => { + await Deno.readDir("bad_dir_name")[Symbol.asyncIterator]().next(); + }, + Deno.errors.NotFound, + `readdir 'bad_dir_name'`, + ); +}); -- cgit v1.2.3