From d3299c2d6c036d3f016ef1abbe9c06e9b1656fd0 Mon Sep 17 00:00:00 2001 From: David Sherret Date: Mon, 28 Nov 2022 17:48:56 -0500 Subject: fix(npm): don't resolve JS files when resolving types (#16854) Closes #16851 --- cli/tests/testdata/npm/no_types_cjs/main.ts | 7 +++++++ .../testdata/npm/registry/@denotest/no-types-cjs/1.0.0/main.js | 6 ++++++ .../npm/registry/@denotest/no-types-cjs/1.0.0/package.json | 5 +++++ 3 files changed, 18 insertions(+) create mode 100644 cli/tests/testdata/npm/no_types_cjs/main.ts create mode 100644 cli/tests/testdata/npm/registry/@denotest/no-types-cjs/1.0.0/main.js create mode 100644 cli/tests/testdata/npm/registry/@denotest/no-types-cjs/1.0.0/package.json (limited to 'cli/tests/testdata') diff --git a/cli/tests/testdata/npm/no_types_cjs/main.ts b/cli/tests/testdata/npm/no_types_cjs/main.ts new file mode 100644 index 000000000..32458e839 --- /dev/null +++ b/cli/tests/testdata/npm/no_types_cjs/main.ts @@ -0,0 +1,7 @@ +import mod from "npm:@denotest/no-types-cjs"; + +// it actually returns a `number` and has that in its +// jsdocs, but the jsdocs should not have been resolved so +// this should type check just fine +const value: string = mod(); +console.log(value); diff --git a/cli/tests/testdata/npm/registry/@denotest/no-types-cjs/1.0.0/main.js b/cli/tests/testdata/npm/registry/@denotest/no-types-cjs/1.0.0/main.js new file mode 100644 index 000000000..bb6cbdb02 --- /dev/null +++ b/cli/tests/testdata/npm/registry/@denotest/no-types-cjs/1.0.0/main.js @@ -0,0 +1,6 @@ +/** + * @return {number} + */ + module.exports = function () { + return 5; +}; diff --git a/cli/tests/testdata/npm/registry/@denotest/no-types-cjs/1.0.0/package.json b/cli/tests/testdata/npm/registry/@denotest/no-types-cjs/1.0.0/package.json new file mode 100644 index 000000000..60b8a0285 --- /dev/null +++ b/cli/tests/testdata/npm/registry/@denotest/no-types-cjs/1.0.0/package.json @@ -0,0 +1,5 @@ +{ + "name": "@denotest/no-types-cjs", + "version": "1.0.0", + "main": "./main.js" +} -- cgit v1.2.3