From 5c7f76c570bc099c4e60b38443194c1890808a7f Mon Sep 17 00:00:00 2001 From: David Sherret Date: Thu, 6 Apr 2023 21:41:19 -0400 Subject: fix(npm): reload an npm package's dependency's information when version not found (#18622) This reloads an npm package's dependency's information when a version/version req/tag is not found. This PR applies only to dependencies of npm packages. It does NOT yet cause npm specifiers to have their dependency information cache busted. That requires a different solution, but this should help cache bust in more scenarios. Part of #16901, but doesn't close it yet --- cli/tests/testdata/npm/deno_run_non_existent.out | 3 ++- .../npm/registry/@denotest/non-existent-dep-version/1.0.0/index.js | 1 + .../registry/@denotest/non-existent-dep-version/1.0.0/package.json | 7 +++++++ .../npm/registry/@denotest/non-existent-dep/1.0.0/index.js | 1 + .../npm/registry/@denotest/non-existent-dep/1.0.0/package.json | 7 +++++++ 5 files changed, 18 insertions(+), 1 deletion(-) create mode 100644 cli/tests/testdata/npm/registry/@denotest/non-existent-dep-version/1.0.0/index.js create mode 100644 cli/tests/testdata/npm/registry/@denotest/non-existent-dep-version/1.0.0/package.json create mode 100644 cli/tests/testdata/npm/registry/@denotest/non-existent-dep/1.0.0/index.js create mode 100644 cli/tests/testdata/npm/registry/@denotest/non-existent-dep/1.0.0/package.json (limited to 'cli/tests/testdata') diff --git a/cli/tests/testdata/npm/deno_run_non_existent.out b/cli/tests/testdata/npm/deno_run_non_existent.out index 3bb6d146c..47021e00c 100644 --- a/cli/tests/testdata/npm/deno_run_non_existent.out +++ b/cli/tests/testdata/npm/deno_run_non_existent.out @@ -1,2 +1,3 @@ Download http://localhost:4545/npm/registry/mkdirp -error: Could not find npm package 'mkdirp' matching '0.5.125'. Try retrieving the latest npm package information by running with --reload +Download http://localhost:4545/npm/registry/mkdirp +error: Could not find npm package 'mkdirp' matching '0.5.125'. diff --git a/cli/tests/testdata/npm/registry/@denotest/non-existent-dep-version/1.0.0/index.js b/cli/tests/testdata/npm/registry/@denotest/non-existent-dep-version/1.0.0/index.js new file mode 100644 index 000000000..f4e8d9d29 --- /dev/null +++ b/cli/tests/testdata/npm/registry/@denotest/non-existent-dep-version/1.0.0/index.js @@ -0,0 +1 @@ +module.exports = 5; diff --git a/cli/tests/testdata/npm/registry/@denotest/non-existent-dep-version/1.0.0/package.json b/cli/tests/testdata/npm/registry/@denotest/non-existent-dep-version/1.0.0/package.json new file mode 100644 index 000000000..0533da432 --- /dev/null +++ b/cli/tests/testdata/npm/registry/@denotest/non-existent-dep-version/1.0.0/package.json @@ -0,0 +1,7 @@ +{ + "name": "@denotest/non-existent-dep-version", + "version": "1.0.0", + "dependencies": { + "@denotest/esm-basic": "=99.99.99" + } +} diff --git a/cli/tests/testdata/npm/registry/@denotest/non-existent-dep/1.0.0/index.js b/cli/tests/testdata/npm/registry/@denotest/non-existent-dep/1.0.0/index.js new file mode 100644 index 000000000..f4e8d9d29 --- /dev/null +++ b/cli/tests/testdata/npm/registry/@denotest/non-existent-dep/1.0.0/index.js @@ -0,0 +1 @@ +module.exports = 5; diff --git a/cli/tests/testdata/npm/registry/@denotest/non-existent-dep/1.0.0/package.json b/cli/tests/testdata/npm/registry/@denotest/non-existent-dep/1.0.0/package.json new file mode 100644 index 000000000..4d5f8c5a2 --- /dev/null +++ b/cli/tests/testdata/npm/registry/@denotest/non-existent-dep/1.0.0/package.json @@ -0,0 +1,7 @@ +{ + "name": "@denotest/non-existent-dep", + "version": "1.0.0", + "dependencies": { + "@denotest/non-existent": "1.0" + } +} -- cgit v1.2.3