From 52ad1ef154d352529c4ad4857ab82d8478aeb105 Mon Sep 17 00:00:00 2001
From: Luca Casonato <hello@lcas.dev>
Date: Wed, 24 Jan 2024 22:24:52 +0100
Subject: feat(publish): give diagnostic on invalid package files (#22082)

---
 cli/tests/testdata/publish/invalid_path.out                  | 11 +++++++++++
 cli/tests/testdata/publish/invalid_path/deno.json            |  7 +++++++
 cli/tests/testdata/publish/invalid_path/mod.ts               |  3 +++
 cli/tests/testdata/publish/invalid_path/path with spaces.txt |  0
 cli/tests/testdata/publish/symlink.out                       | 11 +++++++++++
 cli/tests/testdata/publish/symlink/deno.json                 |  7 +++++++
 cli/tests/testdata/publish/symlink/mod.ts                    |  3 +++
 cli/tests/testdata/publish/symlink/symlink                   |  1 +
 8 files changed, 43 insertions(+)
 create mode 100644 cli/tests/testdata/publish/invalid_path.out
 create mode 100644 cli/tests/testdata/publish/invalid_path/deno.json
 create mode 100644 cli/tests/testdata/publish/invalid_path/mod.ts
 create mode 100644 cli/tests/testdata/publish/invalid_path/path with spaces.txt
 create mode 100644 cli/tests/testdata/publish/symlink.out
 create mode 100644 cli/tests/testdata/publish/symlink/deno.json
 create mode 100644 cli/tests/testdata/publish/symlink/mod.ts
 create mode 120000 cli/tests/testdata/publish/symlink/symlink

(limited to 'cli/tests/testdata')

diff --git a/cli/tests/testdata/publish/invalid_path.out b/cli/tests/testdata/publish/invalid_path.out
new file mode 100644
index 000000000..cd3e92e0c
--- /dev/null
+++ b/cli/tests/testdata/publish/invalid_path.out
@@ -0,0 +1,11 @@
+Checking fast check type graph for errors...
+Ensuring type checks...
+Check file://[WILDCARD]mod.ts
+error[invalid-path]: package path must not contain whitespace (found ' ')
+ --> [WILDCARD]path with spaces.txt
+  = hint: rename or remove the file, or add it to 'publish.exclude' in the config file
+
+  info: to portably support all platforms, including windows, the allowed characters in package paths are limited
+  docs: https://jsr.io/go/invalid-path
+
+error: Found 1 problem
diff --git a/cli/tests/testdata/publish/invalid_path/deno.json b/cli/tests/testdata/publish/invalid_path/deno.json
new file mode 100644
index 000000000..213a7cec6
--- /dev/null
+++ b/cli/tests/testdata/publish/invalid_path/deno.json
@@ -0,0 +1,7 @@
+{
+  "name": "@foo/bar",
+  "version": "1.0.0",
+  "exports": {
+    ".": "./mod.ts"
+  }
+}
diff --git a/cli/tests/testdata/publish/invalid_path/mod.ts b/cli/tests/testdata/publish/invalid_path/mod.ts
new file mode 100644
index 000000000..9e217d9b0
--- /dev/null
+++ b/cli/tests/testdata/publish/invalid_path/mod.ts
@@ -0,0 +1,3 @@
+export function foobar(): string {
+  return "string";
+}
diff --git a/cli/tests/testdata/publish/invalid_path/path with spaces.txt b/cli/tests/testdata/publish/invalid_path/path with spaces.txt
new file mode 100644
index 000000000..e69de29bb
diff --git a/cli/tests/testdata/publish/symlink.out b/cli/tests/testdata/publish/symlink.out
new file mode 100644
index 000000000..5befec4f9
--- /dev/null
+++ b/cli/tests/testdata/publish/symlink.out
@@ -0,0 +1,11 @@
+Checking fast check type graph for errors...
+Ensuring type checks...
+Check [WILDCARD]mod.ts
+warning[unsupported-file-type]: unsupported file type 'symlink'
+ --> [WILDCARD]symlink
+  = hint: remove the file, or add it to 'publish.exclude' in the config file
+
+  info: only files and directories are supported
+  info: the file was ignored and will not be published
+
+Warning Aborting due to --dry-run
diff --git a/cli/tests/testdata/publish/symlink/deno.json b/cli/tests/testdata/publish/symlink/deno.json
new file mode 100644
index 000000000..213a7cec6
--- /dev/null
+++ b/cli/tests/testdata/publish/symlink/deno.json
@@ -0,0 +1,7 @@
+{
+  "name": "@foo/bar",
+  "version": "1.0.0",
+  "exports": {
+    ".": "./mod.ts"
+  }
+}
diff --git a/cli/tests/testdata/publish/symlink/mod.ts b/cli/tests/testdata/publish/symlink/mod.ts
new file mode 100644
index 000000000..9e217d9b0
--- /dev/null
+++ b/cli/tests/testdata/publish/symlink/mod.ts
@@ -0,0 +1,3 @@
+export function foobar(): string {
+  return "string";
+}
diff --git a/cli/tests/testdata/publish/symlink/symlink b/cli/tests/testdata/publish/symlink/symlink
new file mode 120000
index 000000000..0df9bcd04
--- /dev/null
+++ b/cli/tests/testdata/publish/symlink/symlink
@@ -0,0 +1 @@
+./mod.ts
\ No newline at end of file
-- 
cgit v1.2.3