From 0733943fe7de30fa54d6cd8ee34f7393e8bb7482 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Thu, 15 Jun 2023 20:36:33 +0200 Subject: fix(cli): avoid crash on import of invalid module names (#19523) Fixes https://github.com/denoland/deno/issues/17748 Closes #17770 Co-authored-by: Anton Bershanskiy Co-authored-by: David Sherret --- cli/tests/testdata/npm/dynamic_import_invalid_package_name/main.out | 6 ++++++ cli/tests/testdata/npm/dynamic_import_invalid_package_name/main.ts | 6 ++++++ 2 files changed, 12 insertions(+) create mode 100644 cli/tests/testdata/npm/dynamic_import_invalid_package_name/main.out create mode 100644 cli/tests/testdata/npm/dynamic_import_invalid_package_name/main.ts (limited to 'cli/tests/testdata') diff --git a/cli/tests/testdata/npm/dynamic_import_invalid_package_name/main.out b/cli/tests/testdata/npm/dynamic_import_invalid_package_name/main.out new file mode 100644 index 000000000..0e9de5f25 --- /dev/null +++ b/cli/tests/testdata/npm/dynamic_import_invalid_package_name/main.out @@ -0,0 +1,6 @@ +Download http://localhost:4545/npm/registry/ws%3A +FAILED +TypeError: npm package 'ws:' does not exist. + at async file:///[WILDCARD]/dynamic_import_invalid_package_name/main.ts:2:3 { + code: "ERR_MODULE_NOT_FOUND" +} diff --git a/cli/tests/testdata/npm/dynamic_import_invalid_package_name/main.ts b/cli/tests/testdata/npm/dynamic_import_invalid_package_name/main.ts new file mode 100644 index 000000000..368ccc282 --- /dev/null +++ b/cli/tests/testdata/npm/dynamic_import_invalid_package_name/main.ts @@ -0,0 +1,6 @@ +try { + await import(`npm:${"ws:"}`); +} catch (err) { + console.log("FAILED"); + console.log(err); +} -- cgit v1.2.3