From 3d8a4d3b81e107bbb152ad69047f64d16ca800f3 Mon Sep 17 00:00:00 2001 From: Nayeem Rahman Date: Wed, 26 Apr 2023 21:23:28 +0100 Subject: feat(cli): don't check permissions for statically analyzable dynamic imports (#18713) Closes #17697 Closes #17658 --- cli/tests/testdata/workers/dynamic_remote.ts | 2 +- cli/tests/testdata/workers/permissions_dynamic_remote.ts.out | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'cli/tests/testdata/workers') diff --git a/cli/tests/testdata/workers/dynamic_remote.ts b/cli/tests/testdata/workers/dynamic_remote.ts index 381c7f374..54e4a4714 100644 --- a/cli/tests/testdata/workers/dynamic_remote.ts +++ b/cli/tests/testdata/workers/dynamic_remote.ts @@ -1,2 +1,2 @@ // This file doesn't really exist, but it doesn't matter, a "PermissionsDenied" error should be thrown. -await import("https://example.com/some/file.ts"); +await import("" + "https://example.com/some/file.ts"); diff --git a/cli/tests/testdata/workers/permissions_dynamic_remote.ts.out b/cli/tests/testdata/workers/permissions_dynamic_remote.ts.out index cd1884c7e..91f3cc6d5 100644 --- a/cli/tests/testdata/workers/permissions_dynamic_remote.ts.out +++ b/cli/tests/testdata/workers/permissions_dynamic_remote.ts.out @@ -1,5 +1,5 @@ error: Uncaught (in worker "") (in promise) TypeError: Requires net access to "example.com", run again with the --allow-net flag -await import("https://example.com/some/file.ts"); +await import("" + "https://example.com/some/file.ts"); ^ at async http://localhost:4545/workers/dynamic_remote.ts:2:1 [WILDCARD]error: Uncaught (in promise) Error: Unhandled error in child worker. -- cgit v1.2.3