From 5edd2771619ddc3cd2f6c76cc93ee64277aa17c2 Mon Sep 17 00:00:00 2001 From: Andreu Botella Date: Sun, 10 Oct 2021 07:03:23 -0700 Subject: feat: Show the URL of streaming WASM modules in stack traces (#12268) WebAssembly modules compiled through `WebAssembly.compile()` and similar non-streaming APIs don't have a URL associated to them, because they have been compiled from a buffer source. In stack traces, V8 will use a URL such as `wasm://wasm/d1c677ea`, with a hash of the module. However, wasm modules compiled through streaming APIs, like `WebAssembly.compileStreaming()`, do have a known URL, which can be obtained from the `Response` object passed into the streaming APIs. And as per the developer-facing display conventions in the WebAssembly Web API spec, this URL should be used in stack traces. This change implements that. --- cli/tests/testdata/unreachable.wasm | Bin 0 -> 42 bytes 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 cli/tests/testdata/unreachable.wasm (limited to 'cli/tests/testdata/unreachable.wasm') diff --git a/cli/tests/testdata/unreachable.wasm b/cli/tests/testdata/unreachable.wasm new file mode 100644 index 000000000..a4110ee39 Binary files /dev/null and b/cli/tests/testdata/unreachable.wasm differ -- cgit v1.2.3